From 522db8fce8a1e5419b1718c2f849bb4b2c3a0474 Mon Sep 17 00:00:00 2001 From: morrislaw Date: Tue, 14 Aug 2018 18:20:03 -0400 Subject: [PATCH] Updated comment for DefaultLoadBalancerName to provide further context --- pkg/cloudprovider/cloud.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/cloudprovider/cloud.go b/pkg/cloudprovider/cloud.go index a2159a9fc79..cc950d4e4ed 100644 --- a/pkg/cloudprovider/cloud.go +++ b/pkg/cloudprovider/cloud.go @@ -62,8 +62,9 @@ type Clusters interface { Master(ctx context.Context, clusterName string) (string, error) } -// TODO(#6812): Use a shorter name that's less likely to be longer than cloud -// providers' name length limits. +// DefaultLoadBalancerName is for getting the load balancer name. It should eventually be removed +// because there is an interface method, LoadBalancer.GetLoadBalancerName, which can be implemented +// per provider and this neutral implementation won't fit every cloud provider's requirements. func DefaultLoadBalancerName(service *v1.Service) string { //GCE requires that the name of a load balancer starts with a lower case letter. ret := "a" + string(service.UID)