github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-01 07:47:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #122540 from my-git9/ut-kubeconfig-1

Browse Source 
kubeadm: increase ut coverage fo phases/kubeconfig
This commit is contained in:
Kubernetes Prow Robot 2024-01-01 15:31:03 +01:00 committed by GitHub
commit 5260488194
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 199 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

199
cmd/kubeadm/app/phases/kubeconfig/kubeconfig_test.go
View File

@ -944,3 +944,202 @@ func TestEnsureAdminClusterRoleBindingImpl(t *testing.T) {
})
}
}
func TestCreateKubeConfigAndCSR(t *testing.T) {
tmpDir := testutil.SetupTempDir(t)
testutil.SetupEmptyFiles(t, tmpDir, "testfile", "bar.csr", "bar.key")
defer func() {
if err := os.RemoveAll(tmpDir); err != nil {
t.Error(err)
}
}()
caCert, caKey := certstestutil.SetupCertificateAuthority(t)
type args struct {
kubeConfigDir string
kubeadmConfig *kubeadmapi.InitConfiguration
name string
spec *kubeConfigSpec
}
tests := []struct {
name string
args args
expectedError bool
}{
{
name: "kubeadmConfig is nil",
args: args{
kubeConfigDir: tmpDir,
kubeadmConfig: nil,
name: "foo",
spec: &kubeConfigSpec{
CACert: caCert,
APIServer: "10.0.0.1",
ClientName: "foo",
TokenAuth: &tokenAuth{Token: "test"},
ClientCertAuth: &clientCertAuth{CAKey: caKey},
},
},
expectedError: true,
},
{
name: "The kubeConfigDir is empty",
args: args{
kubeConfigDir: "",
kubeadmConfig: &kubeadmapi.InitConfiguration{},
name: "foo",
spec: &kubeConfigSpec{
CACert: caCert,
APIServer: "10.0.0.1",
ClientName: "foo",
TokenAuth: &tokenAuth{Token: "test"},
ClientCertAuth: &clientCertAuth{CAKey: caKey},
},
},
expectedError: true,
},
{
name: "The name is empty",
args: args{
kubeConfigDir: tmpDir,
kubeadmConfig: &kubeadmapi.InitConfiguration{},
name: "",
spec: &kubeConfigSpec{
CACert: caCert,
APIServer: "10.0.0.1",
ClientName: "foo",
TokenAuth: &tokenAuth{Token: "test"},
ClientCertAuth: &clientCertAuth{CAKey: caKey},
},
},
expectedError: true,
},
{
name: "The spec is empty",
args: args{
kubeConfigDir: tmpDir,
kubeadmConfig: &kubeadmapi.InitConfiguration{},
name: "foo",
spec: nil,
},
expectedError: true,
},
{
name: "The kubeconfig file already exists",
args: args{
kubeConfigDir: tmpDir,
kubeadmConfig: &kubeadmapi.InitConfiguration{},
name: "testfile",
spec: &kubeConfigSpec{
CACert: caCert,
APIServer: "10.0.0.1",
ClientName: "foo",
TokenAuth: &tokenAuth{Token: "test"},
ClientCertAuth: &clientCertAuth{CAKey: caKey},
},
},
expectedError: true,
},
{
name: "The CSR or key files already exists",
args: args{
kubeConfigDir: tmpDir,
kubeadmConfig: &kubeadmapi.InitConfiguration{},
name: "bar",
spec: &kubeConfigSpec{
CACert: caCert,
APIServer: "10.0.0.1",
ClientName: "foo",
TokenAuth: &tokenAuth{Token: "test"},
ClientCertAuth: &clientCertAuth{CAKey: caKey},
},
},
expectedError: true,
},
{
name: "configuration is valid, expect no errors",
args: args{
kubeConfigDir: tmpDir,
kubeadmConfig: &kubeadmapi.InitConfiguration{},
name: "test",
spec: &kubeConfigSpec{
CACert: caCert,
APIServer: "10.0.0.1",
ClientName: "foo",
TokenAuth: &tokenAuth{Token: "test"},
ClientCertAuth: &clientCertAuth{CAKey: caKey},
},
},
expectedError: false,
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
if err := createKubeConfigAndCSR(tc.args.kubeConfigDir, tc.args.kubeadmConfig, tc.args.name, tc.args.spec); (err != nil) != tc.expectedError {
t.Errorf("createKubeConfigAndCSR() error = %v, wantErr %v", err, tc.expectedError)
}
})
}
}
func TestCreateDefaultKubeConfigsAndCSRFiles(t *testing.T) {
tmpDir := testutil.SetupTempDir(t)
defer func() {
if err := os.RemoveAll(tmpDir); err != nil {
t.Error(err)
}
}()
type args struct {
kubeConfigDir string
kubeadmConfig *kubeadmapi.InitConfiguration
}
tests := []struct {
name string
args args
wantErr bool
}{
{
name: "kubeadmConfig is empty",
args: args{
kubeConfigDir: tmpDir,
kubeadmConfig: &kubeadmapi.InitConfiguration{},
},
wantErr: true,
},
{
name: "The APIEndpoint is invalid",
args: args{
kubeConfigDir: tmpDir,
kubeadmConfig: &kubeadmapi.InitConfiguration{
LocalAPIEndpoint: kubeadmapi.APIEndpoint{
AdvertiseAddress: "x.12.FOo.1",
BindPort: 6443,
},
},
},
wantErr: true,
},
{
name: "The APIEndpoint is valid",
args: args{
kubeConfigDir: tmpDir,
kubeadmConfig: &kubeadmapi.InitConfiguration{
LocalAPIEndpoint: kubeadmapi.APIEndpoint{
AdvertiseAddress: "127.0.0.1",
BindPort: 6443,
},
},
},
wantErr: false,
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
out := &bytes.Buffer{}
if err := CreateDefaultKubeConfigsAndCSRFiles(out, tc.args.kubeConfigDir, tc.args.kubeadmConfig); (err != nil) != tc.wantErr {
t.Errorf("CreateDefaultKubeConfigsAndCSRFiles() error = %v, wantErr %v", err, tc.wantErr)
return
}
})
}
}