github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

Allow list-resources.sh to continue if a resource fails to list

Browse Source 
The list-resources.sh script is used solely by our CI, specifically
kubernetes/test-infra/kubetest with the --check-leaked-resources
flag. Currently if a single resource fails to list, we fail the entire
job.

I think this is too brittle. A review of previous issues on
kubernetes/kubernetes that relate to failure of this script shows that
the issues usually resolve themselves, or would be caught by the diff
of before/after.

Let's instead allow the script to continue listing all resources,
and let kubetest's resource diff fail the job.
This commit is contained in:
Aaron Crickenberger 2020-03-27 23:13:50 -07:00
parent 933c303592
commit 52653195f6
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cluster/gce/list-resources.sh
View File

@ -75,6 +75,9 @@ echo "Provider: ${KUBERNETES_PROVIDER:-}"
# List resources related to instances, filtering by the instance prefix if
# provided.
set +e # do not stop on error
gcloud-list compute instance-templates "name ~ '${INSTANCE_PREFIX}.*'"
gcloud-list compute instance-groups "${ZONE:+"zone:(${ZONE}) AND "}name ~ '${INSTANCE_PREFIX}.*'"
gcloud-list compute instances "${ZONE:+"zone:(${ZONE}) AND "}name ~ '${INSTANCE_PREFIX}.*'"
@ -95,3 +98,5 @@ gcloud-list compute forwarding-rules ${REGION:+"region=(${REGION})"}
gcloud-list compute target-pools ${REGION:+"region=(${REGION})"}
gcloud-list logging sinks
set -e