From 5269e7699027d4e43d9623e21f8f933f35460005 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Mon, 28 Aug 2023 17:55:44 +0200 Subject: [PATCH] scheduler: properly skip DRA events Because of a misplaced `append` (should have been inside if clause, not after it), some handler from a previous loop iteration was added again. This was harmless because the resulting slice was only used for waiting for cache sync, but should better get fixed anyway. --- pkg/scheduler/eventhandlers.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/scheduler/eventhandlers.go b/pkg/scheduler/eventhandlers.go index 5d1fe0dde47..3a22e2541f0 100644 --- a/pkg/scheduler/eventhandlers.go +++ b/pkg/scheduler/eventhandlers.go @@ -447,8 +447,8 @@ func addAllEventHandlers( ); err != nil { return err } + handlers = append(handlers, handlerRegistration) } - handlers = append(handlers, handlerRegistration) case framework.ResourceClaim: if utilfeature.DefaultFeatureGate.Enabled(features.DynamicResourceAllocation) { if handlerRegistration, err = informerFactory.Resource().V1alpha2().ResourceClaims().Informer().AddEventHandler( @@ -456,8 +456,8 @@ func addAllEventHandlers( ); err != nil { return err } + handlers = append(handlers, handlerRegistration) } - handlers = append(handlers, handlerRegistration) case framework.StorageClass: if at&framework.Add != 0 { if handlerRegistration, err = informerFactory.Storage().V1().StorageClasses().Informer().AddEventHandler(