From 52e24a02effa31176b18d15c28408834bee5e787 Mon Sep 17 00:00:00 2001 From: myeunee Date: Mon, 9 Sep 2024 00:34:03 +0900 Subject: [PATCH] Clean up unnecessary else block and redundant variable assignment This PR removes an unnecessary else block and eliminates a redundant variable assignment to improve code readability. --- cmd/kube-scheduler/app/server.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cmd/kube-scheduler/app/server.go b/cmd/kube-scheduler/app/server.go index 7b08b119b4b..c788be0282c 100644 --- a/cmd/kube-scheduler/app/server.go +++ b/cmd/kube-scheduler/app/server.go @@ -133,13 +133,12 @@ for more information about scheduling and the kube-scheduler component.`, // runCommand runs the scheduler. func runCommand(cmd *cobra.Command, opts *options.Options, registryOptions ...Option) error { verflag.PrintAndExitIfRequested() - fg := opts.ComponentGlobalsRegistry.FeatureGateFor(utilversion.DefaultKubeComponent) // Activate logging as soon as possible, after that // show flags with the final logging configuration. - if err := logsapi.ValidateAndApply(opts.Logs, fg); err != nil { + if err := logsapi.ValidateAndApply(opts.Logs, opts.ComponentGlobalsRegistry.FeatureGateFor(utilversion.DefaultKubeComponent)); err != nil { fmt.Fprintf(os.Stderr, "%v\n", err) os.Exit(1) - } + } cliflag.PrintFlags(cmd.Flags()) ctx, cancel := context.WithCancel(context.Background()) @@ -169,11 +168,12 @@ func Run(ctx context.Context, cc *schedulerserverconfig.CompletedConfig, sched * logger.Info("Golang settings", "GOGC", os.Getenv("GOGC"), "GOMAXPROCS", os.Getenv("GOMAXPROCS"), "GOTRACEBACK", os.Getenv("GOTRACEBACK")) // Configz registration. - if cz, err := configz.New("componentconfig"); err == nil { - cz.Set(cc.ComponentConfig) - } else { + cz, err := configz.New("componentconfig") + if err != nil { return fmt.Errorf("unable to register configz: %s", err) } + cz.Set(cc.ComponentConfig) + // Start events processing pipeline. cc.EventBroadcaster.StartRecordingToSink(ctx.Done())