github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-10-11 17:55:42 +00:00
Code Issues Projects Releases Wiki Activity

Create container name after dropped ":" and "@" both separately

Browse Source 
When image has ":" after "@", kubectl create deployment fails due to
invalid container name.

This patch changes to create the container name after drooping ":" and
"@" both separately.
This commit is contained in:
Kenjiro Nakayama
2018-04-08 18:26:39 +09:00
parent bb3887d7dd
commit 5303f78de8
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/kubectl/deployment_test.go
View File

@@ -37,7 +37,7 @@ func TestDeploymentBasicGenerate(t *testing.T) {
{
name: "deployment name and images ok",
deploymentName: "images-name-ok",
images: []string{"nn/image1", "registry/nn/image2", "nn/image3:tag", "nn/image4@digest"},
images: []string{"nn/image1", "registry/nn/image2", "nn/image3:tag", "nn/image4@digest", "nn/image5@sha256:digest"},
expected: &extensionsv1beta1.Deployment{
ObjectMeta: metav1.ObjectMeta{
Name: "images-name-ok",
@@ -58,6 +58,7 @@ func TestDeploymentBasicGenerate(t *testing.T) {
{Name: "image2", Image: "registry/nn/image2"},
{Name: "image3", Image: "nn/image3:tag"},
{Name: "image4", Image: "nn/image4@digest"},
{Name: "image5", Image: "nn/image5@sha256:digest"},
},
},
},