From 5331973fa558bdca56fd5834631a796c3c0772f7 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Fri, 3 Mar 2023 07:45:07 +0100 Subject: [PATCH] verify-govet-levee.sh: optimize "go list" go list -find takes ~60% the time: $ time go list -e ./... | grep -E -v "/(build|third_party|vendor|staging|clientset_generated|hack)/" | md5sum b5593b3f51f3b3cd08c33bbff9627d10 - real 0m2.687s user 0m3.624s sys 0m1.552s $ time go list -find -e ./... | grep -E -v "/(build|third_party|vendor|staging|clientset_generated|hack)/" | md5sum b5593b3f51f3b3cd08c33bbff9627d10 - real 0m1.721s user 0m1.675s sys 0m1.197s https://github.com/kubernetes/kubernetes/pull/116166#discussion_r1123924871 --- hack/verify-govet-levee.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/verify-govet-levee.sh b/hack/verify-govet-levee.sh index aadd4a57fc3..f087d59d1b9 100755 --- a/hack/verify-govet-levee.sh +++ b/hack/verify-govet-levee.sh @@ -43,6 +43,6 @@ CONFIG_FILE="${KUBE_ROOT}/hack/testdata/levee/levee-config.yaml" targets=() while IFS='' read -r line; do targets+=("${line}") -done < <(go list -e ./... | grep -E -v "/(build|third_party|vendor|staging|clientset_generated|hack)/") +done < <(go list --find -e ./... | grep -E -v "/(build|third_party|vendor|staging|clientset_generated|hack)/") go vet -vettool="${LEVEE_BIN}" -config="${CONFIG_FILE}" "${targets[@]}"