diff --git a/hack/.golint_failures b/hack/.golint_failures index 459659107cb..2d13fdd91bd 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -293,7 +293,6 @@ pkg/registry/rbac/clusterrolebinding pkg/registry/rbac/clusterrolebinding/policybased pkg/registry/rbac/reconciliation pkg/registry/rbac/rest -pkg/registry/rbac/role pkg/registry/rbac/role/policybased pkg/registry/rbac/rolebinding pkg/registry/rbac/rolebinding/policybased diff --git a/pkg/registry/rbac/role/doc.go b/pkg/registry/rbac/role/doc.go index 78bd7cc8fc1..c98942ccbf7 100644 --- a/pkg/registry/rbac/role/doc.go +++ b/pkg/registry/rbac/role/doc.go @@ -14,6 +14,6 @@ See the License for the specific language governing permissions and limitations under the License. */ -// Package certificates provides Registry interface and its RESTStorage +// Package role provides Registry interface and its RESTStorage // implementation for storing Role objects. package role // import "k8s.io/kubernetes/pkg/registry/rbac/role" diff --git a/pkg/registry/rbac/role/registry.go b/pkg/registry/rbac/role/registry.go index 30626acf4e7..4df0f14bb34 100644 --- a/pkg/registry/rbac/role/registry.go +++ b/pkg/registry/rbac/role/registry.go @@ -61,6 +61,7 @@ type AuthorizerAdapter struct { Registry Registry } +// GetRole returns the corresponding Role by name in specified namespace func (a AuthorizerAdapter) GetRole(namespace, name string) (*rbacv1.Role, error) { return a.Registry.GetRole(genericapirequest.WithNamespace(genericapirequest.NewContext(), namespace), name, &metav1.GetOptions{}) } diff --git a/pkg/registry/rbac/role/strategy.go b/pkg/registry/rbac/role/strategy.go index b6358b3bfd7..bd578c52aee 100644 --- a/pkg/registry/rbac/role/strategy.go +++ b/pkg/registry/rbac/role/strategy.go @@ -34,7 +34,7 @@ type strategy struct { names.NameGenerator } -// strategy is the default logic that applies when creating and updating +// Strategy is the default logic that applies when creating and updating // Role objects. var Strategy = strategy{legacyscheme.Scheme, names.SimpleNameGenerator}