From f007c68ae9b5516ee4f82bef7279a8a880f780f2 Mon Sep 17 00:00:00 2001 From: andyzhangx Date: Wed, 8 Jul 2020 10:48:58 +0000 Subject: [PATCH] doc: deprecate azure blob disk feature --- pkg/volume/azure_dd/azure_common.go | 4 ++-- pkg/volume/azure_dd/azure_provision.go | 2 +- .../legacy-cloud-providers/azure/azure_blobDiskController.go | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/volume/azure_dd/azure_common.go b/pkg/volume/azure_dd/azure_common.go index 72af23e9d61..f9d995610c2 100644 --- a/pkg/volume/azure_dd/azure_common.go +++ b/pkg/volume/azure_dd/azure_common.go @@ -59,8 +59,8 @@ var ( string(api.AzureDataDiskCachingReadWrite)) supportedDiskKinds = sets.NewString( - string(api.AzureSharedBlobDisk), - string(api.AzureDedicatedBlobDisk), + string(api.AzureSharedBlobDisk), // deprecated + string(api.AzureDedicatedBlobDisk), // deprecated string(api.AzureManagedDisk)) // only for Windows node diff --git a/pkg/volume/azure_dd/azure_provision.go b/pkg/volume/azure_dd/azure_provision.go index af7d0957670..9fe782ec580 100644 --- a/pkg/volume/azure_dd/azure_provision.go +++ b/pkg/volume/azure_dd/azure_provision.go @@ -303,7 +303,7 @@ func (p *azureDiskProvisioner) Provision(selectedNode *v1.Node, allowedTopologie if err != nil { return nil, err } - } else { + } else { // Attention: blob disk feature is deprecated if kind == v1.AzureDedicatedBlobDisk { _, diskURI, _, err = diskController.CreateVolume(name, account, storageAccountType, location, requestGiB) if err != nil { diff --git a/staging/src/k8s.io/legacy-cloud-providers/azure/azure_blobDiskController.go b/staging/src/k8s.io/legacy-cloud-providers/azure/azure_blobDiskController.go index 5ca0d4a287e..871529decae 100644 --- a/staging/src/k8s.io/legacy-cloud-providers/azure/azure_blobDiskController.go +++ b/staging/src/k8s.io/legacy-cloud-providers/azure/azure_blobDiskController.go @@ -40,6 +40,7 @@ import ( "k8s.io/klog/v2" ) +// Attention: blob disk feature is deprecated const ( vhdContainerName = "vhds" useHTTPSForBlobBasedDisk = true