From 65d93bbe48890cc4f6ca097977ced6292c3fbcc9 Mon Sep 17 00:00:00 2001 From: Odin Ugedal Date: Sat, 29 Jun 2019 13:33:45 +0200 Subject: [PATCH] Fix ordering settings in verify bazel In coreutils LC_ALL=C is required to make sorting stable across platoforms and locales. $ echo "a-c\nabc" | LANG=C LC_ALL=C sort a-c abc $ echo "a-c\nabc" | LANG=C sort abc a-c --- hack/update-bazel.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/update-bazel.sh b/hack/update-bazel.sh index 7d3933dc4d9..560adeb808e 100755 --- a/hack/update-bazel.sh +++ b/hack/update-bazel.sh @@ -33,7 +33,7 @@ popd # Find all of the staging repos. while IFS='' read -r repo; do staging_repos+=("${repo}"); done <\ - <(cd "${KUBE_ROOT}/staging/src" && find k8s.io -mindepth 1 -maxdepth 1 -type d | LANG=C sort) + <(cd "${KUBE_ROOT}/staging/src" && find k8s.io -mindepth 1 -maxdepth 1 -type d | LC_ALL=C LANG=C sort) # Save the staging repos into a Starlark list that can be used by Bazel rules. (