diff --git a/pkg/client/clientcmd/overrides.go b/pkg/client/clientcmd/overrides.go index 51f5233d5c0..055f1de5567 100644 --- a/pkg/client/clientcmd/overrides.go +++ b/pkg/client/clientcmd/overrides.go @@ -111,13 +111,7 @@ func RecommendedConfigOverrideFlags(prefix string) ConfigOverrideFlags { // BindAuthInfoFlags is a convenience method to bind the specified flags to their associated variables func BindAuthInfoFlags(authInfo *clientcmdapi.AuthInfo, flags *pflag.FlagSet, flagNames AuthOverrideFlags) { - // TODO short flag names are impossible to prefix. code gets cleaner if we remove them - authPathUsage := "Path to the auth info file. If missing, prompt the user. Only used if using https." - if len(flagNames.AuthPathShort) > 0 { - flags.StringVarP(&authInfo.AuthPath, flagNames.AuthPath, flagNames.AuthPathShort, "", authPathUsage) - } else { - flags.StringVar(&authInfo.AuthPath, flagNames.AuthPath, "", authPathUsage) - } + flags.StringVarP(&authInfo.AuthPath, flagNames.AuthPath, flagNames.AuthPathShort, "", "Path to the auth info file. If missing, prompt the user. Only used if using https.") flags.StringVar(&authInfo.ClientCertificate, flagNames.ClientCertificate, "", "Path to a client key file for TLS.") flags.StringVar(&authInfo.ClientKey, flagNames.ClientKey, "", "Path to a client key file for TLS.") flags.StringVar(&authInfo.Token, flagNames.Token, "", "Bearer token for authentication to the API server.") @@ -125,13 +119,7 @@ func BindAuthInfoFlags(authInfo *clientcmdapi.AuthInfo, flags *pflag.FlagSet, fl // BindClusterFlags is a convenience method to bind the specified flags to their associated variables func BindClusterFlags(clusterInfo *clientcmdapi.Cluster, flags *pflag.FlagSet, flagNames ClusterOverrideFlags) { - // TODO short flag names are impossible to prefix. code gets cleaner if we remove them - apiServerUsage := "The address of the Kubernetes API server" - if len(flagNames.APIServerShort) > 0 { - flags.StringVarP(&clusterInfo.Server, flagNames.APIServer, flagNames.APIServerShort, "", apiServerUsage) - } else { - flags.StringVar(&clusterInfo.Server, flagNames.APIServer, "", apiServerUsage) - } + flags.StringVarP(&clusterInfo.Server, flagNames.APIServer, flagNames.APIServerShort, "", "The address of the Kubernetes API server") flags.StringVar(&clusterInfo.APIVersion, flagNames.APIVersion, "", "The API version to use when talking to the server") flags.StringVar(&clusterInfo.CertificateAuthority, flagNames.CertificateAuthority, "", "Path to a cert. file for the certificate authority.") flags.BoolVar(&clusterInfo.InsecureSkipTLSVerify, flagNames.InsecureSkipTLSVerify, false, "If true, the server's certificate will not be checked for validity. This will make your HTTPS connections insecure.")