github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-05 03:03:40 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #115063 from kannon92/tracking-remove-comments

Browse Source 
tracking with finalizers is the default way for the job controller so comments are not needed that say we are tracking with finalizers
This commit is contained in:
Kubernetes Prow Robot
2023-01-17 07:56:44 -08:00
committed by GitHub
parent 727b5a4b47 4890928b78
commit 5550064bc2
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/job/job_controller_test.go
View File

@@ -238,7 +238,6 @@ func TestControllerSyncJob(t *testing.T) {
expectedConditionReason string
expectedCreatedIndexes sets.Int
// only applicable to tracking with finalizers
expectedPodPatches int
// features
@@ -3112,7 +3111,6 @@ func TestGetPodsForJob(t *testing.T) {
jobDeletedInCache bool
pods []*v1.Pod
wantPods []string
// only applicable to tracking with finalizers
wantPodsFinalizer []string
}{
"only matching": {