github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-20 18:31:15 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #112846 from Richabanker/stability-fix-test

Browse Source 
Add test for internal metric
This commit is contained in:
Kubernetes Prow Robot 2022-10-05 00:00:03 -07:00 committed by GitHub
commit 5556d3336b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
staging/src/k8s.io/component-base/metrics/collector_test.go
View File

@ -63,6 +63,8 @@ func TestBaseCustomCollector(t *testing.T) {
var ( var (
alphaDesc = NewDesc("metric_alpha", "alpha metric", []string{"name"}, nil, alphaDesc = NewDesc("metric_alpha", "alpha metric", []string{"name"}, nil,
ALPHA, "") ALPHA, "")
internalDesc = NewDesc("metric_internal", "internal metrics", []string{"name"}, nil,
INTERNAL, "")
stableDesc = NewDesc("metric_stable", "stable metrics", []string{"name"}, nil, stableDesc = NewDesc("metric_stable", "stable metrics", []string{"name"}, nil,
STABLE, "") STABLE, "")
deprecatedDesc = NewDesc("metric_deprecated", "stable deprecated metrics", []string{"name"}, nil, deprecatedDesc = NewDesc("metric_deprecated", "stable deprecated metrics", []string{"name"}, nil,
@ -72,7 +74,7 @@ func TestBaseCustomCollector(t *testing.T) {
) )
registry := newKubeRegistry(currentVersion) registry := newKubeRegistry(currentVersion)
customCollector := newTestCustomCollector(alphaDesc, stableDesc, deprecatedDesc, hiddenDesc) customCollector := newTestCustomCollector(alphaDesc, internalDesc, stableDesc, deprecatedDesc, hiddenDesc)
if err := registry.CustomRegister(customCollector); err != nil { if err := registry.CustomRegister(customCollector); err != nil {
t.Fatalf("register collector failed with err: %v", err) t.Fatalf("register collector failed with err: %v", err)
@ -82,6 +84,9 @@ func TestBaseCustomCollector(t *testing.T) {
# HELP metric_alpha [ALPHA] alpha metric # HELP metric_alpha [ALPHA] alpha metric
# TYPE metric_alpha gauge # TYPE metric_alpha gauge
metric_alpha{name="value"} 1 metric_alpha{name="value"} 1
# HELP metric_internal [INTERNAL] internal metrics
# TYPE metric_internal gauge
metric_internal{name="value"} 1
# HELP metric_stable [STABLE] stable metrics # HELP metric_stable [STABLE] stable metrics
# TYPE metric_stable gauge # TYPE metric_stable gauge
metric_stable{name="value"} 1 metric_stable{name="value"} 1
@ -91,7 +96,7 @@ func TestBaseCustomCollector(t *testing.T) {
` `
err := testutil.GatherAndCompare(registry, strings.NewReader(expectedMetrics), alphaDesc.fqName, err := testutil.GatherAndCompare(registry, strings.NewReader(expectedMetrics), alphaDesc.fqName,
stableDesc.fqName, deprecatedDesc.fqName, hiddenDesc.fqName) internalDesc.fqName, stableDesc.fqName, deprecatedDesc.fqName, hiddenDesc.fqName)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }