From 55d1b5e3d498cb3b6aab69cdf2577f64b5d6e0e1 Mon Sep 17 00:00:00 2001 From: SataQiu Date: Wed, 24 Apr 2019 16:17:12 +0800 Subject: [PATCH] fix golint failures of pkg/registry/rbac/clusterrole --- hack/.golint_failures | 1 - pkg/registry/rbac/clusterrole/doc.go | 2 +- pkg/registry/rbac/clusterrole/registry.go | 1 + pkg/registry/rbac/clusterrole/strategy.go | 2 +- 4 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hack/.golint_failures b/hack/.golint_failures index 6c557311951..459659107cb 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -288,7 +288,6 @@ pkg/registry/networking/rest pkg/registry/node/rest pkg/registry/policy/poddisruptionbudget/storage pkg/registry/policy/rest -pkg/registry/rbac/clusterrole pkg/registry/rbac/clusterrole/policybased pkg/registry/rbac/clusterrolebinding pkg/registry/rbac/clusterrolebinding/policybased diff --git a/pkg/registry/rbac/clusterrole/doc.go b/pkg/registry/rbac/clusterrole/doc.go index 248cc95b2a8..bc1745ec17f 100644 --- a/pkg/registry/rbac/clusterrole/doc.go +++ b/pkg/registry/rbac/clusterrole/doc.go @@ -14,6 +14,6 @@ See the License for the specific language governing permissions and limitations under the License. */ -// Package certificates provides Registry interface and its RESTStorage +// Package clusterrole provides Registry interface and its RESTStorage // implementation for storing ClusterRole objects. package clusterrole // import "k8s.io/kubernetes/pkg/registry/rbac/clusterrole" diff --git a/pkg/registry/rbac/clusterrole/registry.go b/pkg/registry/rbac/clusterrole/registry.go index 5fdc5024df9..1c572d1af98 100644 --- a/pkg/registry/rbac/clusterrole/registry.go +++ b/pkg/registry/rbac/clusterrole/registry.go @@ -61,6 +61,7 @@ type AuthorizerAdapter struct { Registry Registry } +// GetClusterRole returns the corresponding ClusterRole by name func (a AuthorizerAdapter) GetClusterRole(name string) (*rbacv1.ClusterRole, error) { return a.Registry.GetClusterRole(genericapirequest.NewContext(), name, &metav1.GetOptions{}) } diff --git a/pkg/registry/rbac/clusterrole/strategy.go b/pkg/registry/rbac/clusterrole/strategy.go index 10a3f850b60..710b0f8d493 100644 --- a/pkg/registry/rbac/clusterrole/strategy.go +++ b/pkg/registry/rbac/clusterrole/strategy.go @@ -34,7 +34,7 @@ type strategy struct { names.NameGenerator } -// strategy is the default logic that applies when creating and updating +// Strategy is the default logic that applies when creating and updating // ClusterRole objects. var Strategy = strategy{legacyscheme.Scheme, names.SimpleNameGenerator}