github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 18:24:07 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #66209 from tianshapjq/should-not-fmtprintf

Browse Source 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

should not fmt.printf in the e2e test

**What this PR does / why we need it**:
should not fmt.printf in the e2e test

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
none
```
This commit is contained in:
Kubernetes Submit Queue 2018-08-17 02:27:10 -07:00 committed by GitHub
commit 56d1b2d8fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/e2e/framework/authorizer_util.go
View File

@ -17,7 +17,7 @@ limitations under the License.
package framework package framework
import ( import (
"fmt" "github.com/golang/glog"
"sync" "sync"
"time" "time"
@ -62,7 +62,7 @@ func WaitForNamedAuthorizationUpdate(c v1beta1authorization.SubjectAccessReviews
// GKE doesn't enable the SAR endpoint. Without this endpoint, we cannot determine if the policy engine // GKE doesn't enable the SAR endpoint. Without this endpoint, we cannot determine if the policy engine
// has adjusted as expected. In this case, simply wait one second and hope it's up to date // has adjusted as expected. In this case, simply wait one second and hope it's up to date
if apierrors.IsNotFound(err) { if apierrors.IsNotFound(err) {
fmt.Printf("SubjectAccessReview endpoint is missing\n") glog.Info("SubjectAccessReview endpoint is missing")
time.Sleep(1 * time.Second) time.Sleep(1 * time.Second)
return true, nil return true, nil
} }
@ -94,7 +94,7 @@ func BindClusterRole(c v1beta1rbac.ClusterRoleBindingsGetter, clusterRole, ns st
// if we failed, don't fail the entire test because it may still work. RBAC may simply be disabled. // if we failed, don't fail the entire test because it may still work. RBAC may simply be disabled.
if err != nil { if err != nil {
fmt.Printf("Error binding clusterrole/%s for %q for %v\n", clusterRole, ns, subjects) glog.Errorf("Error binding clusterrole/%s for %q for %v\n", clusterRole, ns, subjects)
} }
} }
@ -124,7 +124,7 @@ func bindInNamespace(c v1beta1rbac.RoleBindingsGetter, roleType, role, ns string
// if we failed, don't fail the entire test because it may still work. RBAC may simply be disabled. // if we failed, don't fail the entire test because it may still work. RBAC may simply be disabled.
if err != nil { if err != nil {
fmt.Printf("Error binding %s/%s into %q for %v\n", roleType, role, ns, subjects) glog.Errorf("Error binding %s/%s into %q for %v\n", roleType, role, ns, subjects)
} }
} }

4
test/e2e/instrumentation/monitoring/prometheus.go
View File

@ -238,7 +238,7 @@ func fetchPrometheusTargetDiscovery(c clientset.Interface) (TargetDiscovery, err
Raw() Raw()
var qres promTargetsResponse var qres promTargetsResponse
if err != nil { if err != nil {
fmt.Printf(string(response)) framework.Logf(string(response))
return qres.Data, err return qres.Data, err
} }
err = json.Unmarshal(response, &qres) err = json.Unmarshal(response, &qres)
@ -297,7 +297,7 @@ func queryPrometheus(c clientset.Interface, query string, start, end time.Time,
Do(). Do().
Raw() Raw()
if err != nil { if err != nil {
fmt.Printf(string(response)) framework.Logf(string(response))
return nil, err return nil, err
} }
var qres promQueryResponse var qres promQueryResponse

7
test/e2e/node/events.go
View File

@ -17,7 +17,6 @@ limitations under the License.
package node package node
import ( import (
"fmt"
"strconv" "strconv"
"time" "time"
@ -89,7 +88,7 @@ var _ = SIGDescribe("Events", func() {
if err != nil { if err != nil {
framework.Failf("Failed to get pod: %v", err) framework.Failf("Failed to get pod: %v", err)
} }
fmt.Printf("%+v\n", podWithUid) framework.Logf("%+v\n", podWithUid)
var events *v1.EventList var events *v1.EventList
// Check for scheduler event about the pod. // Check for scheduler event about the pod.
By("checking for scheduler event about the pod") By("checking for scheduler event about the pod")
@ -106,7 +105,7 @@ var _ = SIGDescribe("Events", func() {
return false, err return false, err
} }
if len(events.Items) > 0 { if len(events.Items) > 0 {
fmt.Println("Saw scheduler event for our pod.") framework.Logf("Saw scheduler event for our pod.")
return true, nil return true, nil
} }
return false, nil return false, nil
@ -126,7 +125,7 @@ var _ = SIGDescribe("Events", func() {
return false, err return false, err
} }
if len(events.Items) > 0 { if len(events.Items) > 0 {
fmt.Println("Saw kubelet event for our pod.") framework.Logf("Saw kubelet event for our pod.")
return true, nil return true, nil
} }
return false, nil return false, nil