github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 19:01:49 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #93464 from knight42/fix/flaky-ep-test

Browse Source 
test: deflake TestRecycleSlices test
This commit is contained in:
Kubernetes Prow Robot 2020-07-27 15:15:08 -07:00 committed by GitHub
commit 575c4925be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
pkg/controller/endpointslicemirroring/reconciler_helpers_test.go
View File

@ -17,6 +17,7 @@ limitations under the License.
package endpointslicemirroring
import (
"sort"
"testing"
discovery "k8s.io/api/discovery/v1beta1"
@ -50,8 +51,8 @@ func TestRecycleSlices(t *testing.T) {
},
expectedSlices: &slicesByAction{
toUpdate: []*discovery.EndpointSlice{
simpleEndpointSlice("baz", "10.2.3.4", discovery.AddressTypeIPv4),
simpleEndpointSlice("bar", "10.1.2.3", discovery.AddressTypeIPv4),
simpleEndpointSlice("baz", "10.2.3.4", discovery.AddressTypeIPv4),
},
},
}, {
@ -122,11 +123,19 @@ func TestRecycleSlices(t *testing.T) {
for _, tc := range testCases {
t.Run(tc.testName, func(t *testing.T) {
recycleSlices(tc.startingSlices)
startingSlices := tc.startingSlices
recycleSlices(startingSlices)
expectEqualSlices(t, tc.startingSlices.toCreate, tc.expectedSlices.toCreate)
expectEqualSlices(t, tc.startingSlices.toUpdate, tc.expectedSlices.toUpdate)
expectEqualSlices(t, tc.startingSlices.toDelete, tc.expectedSlices.toDelete)
unorderedSlices := [][]*discovery.EndpointSlice{startingSlices.toCreate, startingSlices.toUpdate, startingSlices.toDelete}
for _, actual := range unorderedSlices {
sort.Slice(actual, func(i, j int) bool {
return actual[i].Name < actual[j].Name
})
}
expectEqualSlices(t, startingSlices.toCreate, tc.expectedSlices.toCreate)
expectEqualSlices(t, startingSlices.toUpdate, tc.expectedSlices.toUpdate)
expectEqualSlices(t, startingSlices.toDelete, tc.expectedSlices.toDelete)
})
}
}