From 5777e8740efc443a474f5ea1762d4beec794e247 Mon Sep 17 00:00:00 2001 From: "Lubomir I. Ivanov" Date: Tue, 7 Jul 2020 22:15:43 +0300 Subject: [PATCH] kubeadm: deprecate "kubeadm alpha kubelet config enable-dynamic" Deprecate the command and recommend users to follow the official guide at the k8s.io website instead. --- cmd/kubeadm/app/cmd/alpha/kubelet.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/cmd/kubeadm/app/cmd/alpha/kubelet.go b/cmd/kubeadm/app/cmd/alpha/kubelet.go index 9f6bf7daa0d..598f74df3d6 100644 --- a/cmd/kubeadm/app/cmd/alpha/kubelet.go +++ b/cmd/kubeadm/app/cmd/alpha/kubelet.go @@ -34,7 +34,7 @@ var ( Enable or update dynamic kubelet configuration for a Node, against the kubelet-config-1.X ConfigMap in the cluster, where X is the minor version of the desired kubelet version. - WARNING: This feature is still experimental, and disabled by default. Enable only if you know what you are doing, as it + WARNING: This kubeadm feature is deprecated. Enable only if you know what you are doing, as it may have surprising side-effects at this stage. ` + cmdutil.AlphaDisclaimer) @@ -43,7 +43,7 @@ var ( # Enable dynamic kubelet configuration for a Node. kubeadm alpha phase kubelet enable-dynamic-config --node-name node-1 --kubelet-version %s - WARNING: This feature is still experimental, and disabled by default. Enable only if you know what you are doing, as it + WARNING: This kubeadm feature is deprecated. Enable only if you know what you are doing, as it may have surprising side-effects at this stage. `, constants.CurrentKubernetesVersion)) ) @@ -80,9 +80,11 @@ func newCmdKubeletConfigEnableDynamic() *cobra.Command { cmd := &cobra.Command{ Use: "enable-dynamic", - Short: "EXPERIMENTAL: Enable or update dynamic kubelet configuration for a Node", + Short: "DEPRECATED: Enable or update dynamic kubelet configuration for a Node", Long: kubeletConfigEnableDynamicLongDesc, Example: kubeletConfigEnableDynamicExample, + Deprecated: "This command is deprecated and will be removed in a future release. Please defer to the official \"Dynamic Kubelet Configuration\" " + + "guide at k8s.io if you wish to use this feature", RunE: func(cmd *cobra.Command, args []string) error { if len(nodeName) == 0 { return errors.New("the --node-name argument is required")