From 57782459e68916691ac93fa8e434706de0af8e46 Mon Sep 17 00:00:00 2001 From: David Pratt Date: Tue, 9 Feb 2016 12:06:02 -0600 Subject: [PATCH] Log missing public IP from AWS metadata. --- pkg/cloudprovider/providers/aws/aws.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/cloudprovider/providers/aws/aws.go b/pkg/cloudprovider/providers/aws/aws.go index b876cfe421d..628aa62fd09 100644 --- a/pkg/cloudprovider/providers/aws/aws.go +++ b/pkg/cloudprovider/providers/aws/aws.go @@ -657,11 +657,14 @@ func (aws *AWSCloud) NodeAddresses(name string) ([]api.NodeAddress, error) { return nil, err } addresses = append(addresses, api.NodeAddress{Type: api.NodeInternalIP, Address: internalIP}) + // Legacy compatibility: the private ip was the legacy host ip addresses = append(addresses, api.NodeAddress{Type: api.NodeLegacyHostIP, Address: internalIP}) externalIP, err := aws.metadata.GetMetadata("public-ipv4") if err != nil { - //Perhaps only log this as a warning the first time this method is called? + //TODO: It would be nice to be able to determine the reason for the failure, + // but the AWS client masks all failures with the same error description. + glog.V(2).Info("Could not determine public IP from AWS metadata.") } else { addresses = append(addresses, api.NodeAddress{Type: api.NodeExternalIP, Address: externalIP}) }