github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 06:27:05 +00:00
Code Issues Projects Releases Wiki Activity

Adding comment for maxValidDepth check.

Browse Source
This commit is contained in:
Cici Huang 2022-07-13 21:35:38 +00:00
parent c67e914373
commit 58303deee7
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/cel/validation_test.go
View File

@ -1929,6 +1929,10 @@ func TestCELValidationContextCancellation(t *testing.T) {
} }
} }
// This is the most recursive operations we expect to be able to include in an expression.
// This number could get larger with more improvements in the grammar or ANTLR stack, but should *never* decrease or previously valid expressions could be treated as invalid.
const maxValidDepth = 243
// TestCELMaxRecursionDepth tests CEL setting for maxRecursionDepth. // TestCELMaxRecursionDepth tests CEL setting for maxRecursionDepth.
func TestCELMaxRecursionDepth(t *testing.T) { func TestCELMaxRecursionDepth(t *testing.T) {
tests := []struct { tests := []struct {
@ -1946,10 +1950,10 @@ func TestCELMaxRecursionDepth(t *testing.T) {
obj: objs(true), obj: objs(true),
schema: schemas(booleanType), schema: schemas(booleanType),
valid: []string{ valid: []string{
strings.Repeat("self.val1"+" == ", 242) + "self.val1", strings.Repeat("self.val1"+" == ", maxValidDepth-1) + "self.val1",
}, },
errors: map[string]string{ errors: map[string]string{
strings.Repeat("self.val1"+" == ", 243) + "self.val1": "max recursion depth exceeded", strings.Repeat("self.val1"+" == ", maxValidDepth) + "self.val1": "max recursion depth exceeded",
}, },
}, },
} }