From 1d8ab839acc723db8ee76d28fddc53804ef48db7 Mon Sep 17 00:00:00 2001 From: 00255991 Date: Thu, 16 Sep 2021 15:31:03 +0800 Subject: [PATCH] parameter 'disabled-metrics' is invalid --- staging/src/k8s.io/component-base/metrics/options.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/component-base/metrics/options.go b/staging/src/k8s.io/component-base/metrics/options.go index 91a76ba7e51..456fe0b0a30 100644 --- a/staging/src/k8s.io/component-base/metrics/options.go +++ b/staging/src/k8s.io/component-base/metrics/options.go @@ -58,8 +58,8 @@ func (o *Options) Validate() []error { // AddFlags adds flags for exposing component metrics. func (o *Options) AddFlags(fs *pflag.FlagSet) { - if o != nil { - o = NewOptions() + if o == nil { + return } fs.StringVar(&o.ShowHiddenMetricsForVersion, "show-hidden-metrics-for-version", o.ShowHiddenMetricsForVersion, "The previous version for which you want to show hidden metrics. "+