From 58924c2de52b7eab88053622a6bb7f19787caee0 Mon Sep 17 00:00:00 2001 From: Morgan Bauer Date: Tue, 26 May 2020 14:08:27 -0700 Subject: [PATCH] explicitly fail if no images are found when running remote tests The previous implementation succeeds if no images are run. This causes silent failures when image matchers are provided that do not match any image. --- test/e2e_node/runner/remote/run_remote.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/e2e_node/runner/remote/run_remote.go b/test/e2e_node/runner/remote/run_remote.go index c88865a3f89..f7a3cd8ab6d 100644 --- a/test/e2e_node/runner/remote/run_remote.go +++ b/test/e2e_node/runner/remote/run_remote.go @@ -244,6 +244,10 @@ func main() { klog.Fatalf("Could not retrieve list of images based on image prefix %q and family %q: %v", imageConfig.ImageRegex, imageConfig.ImageFamily, err) } + if len(images) == 0 { // if we have no images we can't run anything + klog.Fatalf("No matching images retrieved on image prefix %q and family %q: %v", + imageConfig.ImageRegex, imageConfig.ImageFamily, err) + } } else { images = []string{imageConfig.Image} }