From 5947ee3653c9ee280850a62aeeea933d2143c4c1 Mon Sep 17 00:00:00 2001 From: JD Nurme Date: Tue, 14 Dec 2021 21:16:48 +0000 Subject: [PATCH] updated comments --- .../component-base/metrics/prometheus/controllers/metrics.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/staging/src/k8s.io/component-base/metrics/prometheus/controllers/metrics.go b/staging/src/k8s.io/component-base/metrics/prometheus/controllers/metrics.go index 015482e4218..dcf13e1add8 100644 --- a/staging/src/k8s.io/component-base/metrics/prometheus/controllers/metrics.go +++ b/staging/src/k8s.io/component-base/metrics/prometheus/controllers/metrics.go @@ -47,12 +47,9 @@ func newControllerMetrics() *ControllerMetrics { } } -// controller_name and controller_manager should be updated to validate against bounded lists -// this will allow us to confirm they are populated with "good" values. - +// ControllerStarted sets the controllerInstanceCount to 1. // These values use set instead of inc/dec to avoid accidentally double counting // a controller that starts but fails to properly signal when it crashes. -// ControllerStarted sets the controllerInstanceCount to 1. func (a *ControllerMetrics) ControllerStarted(controllerName string, controllerManager string) { a.controllerInstanceCount.With(k8smetrics.Labels{"controller_name": controllerName, "controller_manager": controllerManager}).Set(float64(1)) }