Changing a few remaining instances of passing pods around by value. I

avoided changing api.PodList.Items to []*api.Pod.
This commit is contained in:
Kris Rousey
2015-04-20 11:20:53 -07:00
parent f48d7ad7ee
commit 594f514843
10 changed files with 51 additions and 52 deletions

View File

@@ -187,9 +187,10 @@ func (rm *ReplicationManager) watchControllers(resourceVersion *string) {
}
// Helper function. Also used in pkg/registry/controller, for now.
func FilterActivePods(pods []api.Pod) []api.Pod {
var result []api.Pod
for _, value := range pods {
func FilterActivePods(pods []api.Pod) []*api.Pod {
var result []*api.Pod
for i := range pods {
value := &pods[i]
if api.PodSucceeded != value.Status.Phase &&
api.PodFailed != value.Status.Phase {
result = append(result, value)