From 59b1f5b8b578a35583fda02c458f4854168e3627 Mon Sep 17 00:00:00 2001 From: Janet Kuo Date: Fri, 4 Mar 2016 13:57:34 -0800 Subject: [PATCH] Log contents of pods on creation/update/deletion in controllers --- pkg/controller/deployment/deployment_controller.go | 8 ++++---- pkg/controller/replicaset/replica_set.go | 5 ++++- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/pkg/controller/deployment/deployment_controller.go b/pkg/controller/deployment/deployment_controller.go index 8957072b9a6..fc1890ebe12 100644 --- a/pkg/controller/deployment/deployment_controller.go +++ b/pkg/controller/deployment/deployment_controller.go @@ -310,7 +310,7 @@ func (dc *DeploymentController) addPod(obj interface{}) { if !ok { return } - glog.V(4).Infof("Pod %s created.", pod.Name) + glog.V(4).Infof("Pod %s created: %+v.", pod.Name, pod) if d := dc.getDeploymentForPod(pod); d != nil { dc.enqueueDeployment(d) } @@ -324,11 +324,11 @@ func (dc *DeploymentController) updatePod(old, cur interface{}) { return } curPod := cur.(*api.Pod) - glog.V(4).Infof("Pod %s updated.", curPod.Name) + oldPod := old.(*api.Pod) + glog.V(4).Infof("Pod %s updated %+v -> %+v.", curPod.Name, oldPod, curPod) if d := dc.getDeploymentForPod(curPod); d != nil { dc.enqueueDeployment(d) } - oldPod := old.(*api.Pod) if !api.Semantic.DeepEqual(oldPod, curPod) { if oldD := dc.getDeploymentForPod(oldPod); oldD != nil { dc.enqueueDeployment(oldD) @@ -357,7 +357,7 @@ func (dc *DeploymentController) deletePod(obj interface{}) { return } } - glog.V(4).Infof("Pod %s deleted.", pod.Name) + glog.V(4).Infof("Pod %s deleted: %+v.", pod.Name, pod) if d := dc.getDeploymentForPod(pod); d != nil { dc.enqueueDeployment(d) } diff --git a/pkg/controller/replicaset/replica_set.go b/pkg/controller/replicaset/replica_set.go index 09f47a9b238..07fff80c097 100644 --- a/pkg/controller/replicaset/replica_set.go +++ b/pkg/controller/replicaset/replica_set.go @@ -289,6 +289,7 @@ func isReplicaSetMatch(pod *api.Pod, rs *extensions.ReplicaSet) bool { // When a pod is created, enqueue the replica set that manages it and update it's expectations. func (rsc *ReplicaSetController) addPod(obj interface{}) { pod := obj.(*api.Pod) + glog.V(4).Infof("Pod %s created: %+v.", pod.Name, pod) rs := rsc.getPodReplicaSet(pod) if rs == nil { @@ -319,6 +320,8 @@ func (rsc *ReplicaSetController) updatePod(old, cur interface{}) { return } curPod := cur.(*api.Pod) + oldPod := old.(*api.Pod) + glog.V(4).Infof("Pod %s updated %+v -> %+v.", curPod.Name, oldPod, curPod) rs := rsc.getPodReplicaSet(curPod) if rs == nil { return @@ -328,7 +331,6 @@ func (rsc *ReplicaSetController) updatePod(old, cur interface{}) { glog.Errorf("Couldn't get key for replication controller %#v: %v", rs, err) return } - oldPod := old.(*api.Pod) if curPod.DeletionTimestamp != nil && oldPod.DeletionTimestamp == nil { // when a pod is deleted gracefully it's deletion timestamp is first modified to reflect a grace period, @@ -373,6 +375,7 @@ func (rsc *ReplicaSetController) deletePod(obj interface{}) { return } } + glog.V(4).Infof("Pod %s deleted: %+v.", pod.Name, pod) if rs := rsc.getPodReplicaSet(pod); rs != nil { rsKey, err := controller.KeyFunc(rs) if err != nil {