From 59db75f8936fd9a0e9d10901b4836a8e8fd46ab4 Mon Sep 17 00:00:00 2001 From: Dominika Hodovska Date: Wed, 22 Jun 2016 09:51:15 +0200 Subject: [PATCH] kubectl/autoscale: fix tips when validating --max flag bug 1336632 Bugzilla link https://bugzilla.redhat.com/show_bug.cgi?id=1336632 --- pkg/kubectl/cmd/autoscale.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/kubectl/cmd/autoscale.go b/pkg/kubectl/cmd/autoscale.go index 8419ee8ec98..8334ea47cd6 100644 --- a/pkg/kubectl/cmd/autoscale.go +++ b/pkg/kubectl/cmd/autoscale.go @@ -193,8 +193,10 @@ func RunAutoscale(f *cmdutil.Factory, out io.Writer, cmd *cobra.Command, args [] func validateFlags(cmd *cobra.Command) error { errs := []error{} max, min := cmdutil.GetFlagInt(cmd, "max"), cmdutil.GetFlagInt(cmd, "min") - if max < 1 || max < min { - errs = append(errs, fmt.Errorf("--max=MAXPODS is required, and must be at least 1 and --min=MINPODS")) + if max < 1 { + errs = append(errs, fmt.Errorf("--max=MAXPODS is required and must be at least 1")) + } else if max < min { + errs = append(errs, fmt.Errorf("--max=MAXPODS must be larger or equal to --min=MINPODS")) } return utilerrors.NewAggregate(errs) }