From 5a00c42848841b5b9500bdd47476023cded71e77 Mon Sep 17 00:00:00 2001 From: "Bobby (Babak) Salamat" Date: Wed, 21 Feb 2018 12:55:22 -0800 Subject: [PATCH] Minor improvements to scheduling queue --- pkg/scheduler/core/scheduling_queue.go | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/pkg/scheduler/core/scheduling_queue.go b/pkg/scheduler/core/scheduling_queue.go index 2c17a5443ee..acdc1ebc9ae 100644 --- a/pkg/scheduler/core/scheduling_queue.go +++ b/pkg/scheduler/core/scheduling_queue.go @@ -484,29 +484,17 @@ var _ = UnschedulablePods(&UnschedulablePodsMap{}) // Add adds a pod to the unschedulable pods. func (u *UnschedulablePodsMap) Add(pod *v1.Pod) { - podKey := u.keyFunc(pod) - if _, exists := u.pods[podKey]; !exists { - u.pods[podKey] = pod - } + u.pods[u.keyFunc(pod)] = pod } // Delete deletes a pod from the unschedulable pods. func (u *UnschedulablePodsMap) Delete(pod *v1.Pod) { - podKey := u.keyFunc(pod) - if _, exists := u.pods[podKey]; exists { - delete(u.pods, podKey) - } + delete(u.pods, u.keyFunc(pod)) } // Update updates a pod in the unschedulable pods. func (u *UnschedulablePodsMap) Update(pod *v1.Pod) { - podKey := u.keyFunc(pod) - _, exists := u.pods[podKey] - if !exists { - u.Add(pod) - return - } - u.pods[podKey] = pod + u.Add(pod) } // Get returns the pod if a pod with the same key as the key of the given "pod"