github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 03:57:41 +00:00
Code Issues Projects Releases Wiki Activity

Remove unused error return value from internal function

Browse Source
This commit is contained in:
Dan Winship 2023-06-15 05:22:11 -04:00
parent c984d53b31
commit 5bde9404a0
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pkg/proxy/util/utils.go
View File

@ -227,7 +227,7 @@ func MapIPsByIPFamily(ipStrings []string) map[v1.IPFamily][]string {
ipFamilyMap := map[v1.IPFamily][]string{} ipFamilyMap := map[v1.IPFamily][]string{}
for _, ip := range ipStrings { for _, ip := range ipStrings {
// Handle only the valid IPs // Handle only the valid IPs
if ipFamily, err := getIPFamilyFromIP(ip); err == nil { if ipFamily := getIPFamilyFromIP(ip); ipFamily != "" {
ipFamilyMap[ipFamily] = append(ipFamilyMap[ipFamily], ip) ipFamilyMap[ipFamily] = append(ipFamilyMap[ipFamily], ip)
} else { } else {
// this function is called in multiple places. All of which // this function is called in multiple places. All of which
@ -249,7 +249,7 @@ func MapCIDRsByIPFamily(cidrStrings []string) map[v1.IPFamily][]string {
ipFamilyMap := map[v1.IPFamily][]string{} ipFamilyMap := map[v1.IPFamily][]string{}
for _, cidr := range cidrStrings { for _, cidr := range cidrStrings {
// Handle only the valid CIDRs // Handle only the valid CIDRs
if ipFamily, err := getIPFamilyFromCIDR(cidr); err == nil { if ipFamily := getIPFamilyFromCIDR(cidr); ipFamily != "" {
ipFamilyMap[ipFamily] = append(ipFamilyMap[ipFamily], cidr) ipFamilyMap[ipFamily] = append(ipFamilyMap[ipFamily], cidr)
} else { } else {
klog.ErrorS(nil, "Skipping invalid CIDR", "cidr", cidr) klog.ErrorS(nil, "Skipping invalid CIDR", "cidr", cidr)
@ -258,27 +258,29 @@ func MapCIDRsByIPFamily(cidrStrings []string) map[v1.IPFamily][]string {
return ipFamilyMap return ipFamilyMap
} }
func getIPFamilyFromIP(ipStr string) (v1.IPFamily, error) { // Returns the IP family of ipStr, or "" if ipStr can't be parsed as an IP
func getIPFamilyFromIP(ipStr string) v1.IPFamily {
netIP := netutils.ParseIPSloppy(ipStr) netIP := netutils.ParseIPSloppy(ipStr)
if netIP == nil { if netIP == nil {
return "", ErrAddressNotAllowed return ""
} }
if netutils.IsIPv6(netIP) { if netutils.IsIPv6(netIP) {
return v1.IPv6Protocol, nil return v1.IPv6Protocol
} }
return v1.IPv4Protocol, nil return v1.IPv4Protocol
} }
func getIPFamilyFromCIDR(cidrStr string) (v1.IPFamily, error) { // Returns the IP family of cidrStr, or "" if cidrStr can't be parsed as a CIDR
func getIPFamilyFromCIDR(cidrStr string) v1.IPFamily {
_, netCIDR, err := netutils.ParseCIDRSloppy(cidrStr) _, netCIDR, err := netutils.ParseCIDRSloppy(cidrStr)
if err != nil { if err != nil {
return "", ErrAddressNotAllowed return ""
} }
if netutils.IsIPv6CIDR(netCIDR) { if netutils.IsIPv6CIDR(netCIDR) {
return v1.IPv6Protocol, nil return v1.IPv6Protocol
} }
return v1.IPv4Protocol, nil return v1.IPv4Protocol
} }
// OtherIPFamily returns the other ip family // OtherIPFamily returns the other ip family