diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures index 754de9bb8b7..f34220343ca 100644 --- a/hack/.staticcheck_failures +++ b/hack/.staticcheck_failures @@ -3,7 +3,6 @@ cluster/images/etcd/migrate cmd/kube-controller-manager/app cmd/kube-proxy/app cmd/linkcheck -pkg/client/tests pkg/controller/daemon pkg/controller/deployment pkg/controller/disruption diff --git a/pkg/client/tests/listwatch_test.go b/pkg/client/tests/listwatch_test.go index e1b1ba39f97..10d878199ff 100644 --- a/pkg/client/tests/listwatch_test.go +++ b/pkg/client/tests/listwatch_test.go @@ -48,13 +48,12 @@ func parseSelectorOrDie(s string) fields.Selector { // buildQueryValues is a convenience function for knowing if a namespace should be in a query param or not func buildQueryValues(query url.Values) url.Values { v := url.Values{} - if query != nil { - for key, values := range query { - for _, value := range values { - v.Add(key, value) - } + for key, values := range query { + for _, value := range values { + v.Add(key, value) } } + return v } diff --git a/pkg/client/tests/portfoward_test.go b/pkg/client/tests/portfoward_test.go index d6122606deb..b77cea11a0d 100644 --- a/pkg/client/tests/portfoward_test.go +++ b/pkg/client/tests/portfoward_test.go @@ -173,7 +173,7 @@ func TestForwardPorts(t *testing.T) { continue } b := make([]byte, 4) - n, err = clientConn.Read(b) + _, err = clientConn.Read(b) if err != nil && err != io.EOF { t.Errorf("%s: Error reading data: %s", testName, err) server.Close()