github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-17 23:57:49 +00:00
Code Issues Projects Releases Wiki Activity

Fix health check node port leak

Browse Source
This commit is contained in:
bprashanth 2016-10-10 11:31:12 -07:00
parent cb03ed36bd
commit 5cb8e8e1d6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/proxy/iptables/proxier.go
View File

@ -455,18 +455,20 @@ func (proxier *Proxier) OnServiceUpdate(allServices []api.Service) {
info.loadBalancerStatus = *api.LoadBalancerStatusDeepCopy(&service.Status.LoadBalancer) info.loadBalancerStatus = *api.LoadBalancerStatusDeepCopy(&service.Status.LoadBalancer)
info.sessionAffinityType = service.Spec.SessionAffinity info.sessionAffinityType = service.Spec.SessionAffinity
info.loadBalancerSourceRanges = service.Spec.LoadBalancerSourceRanges info.loadBalancerSourceRanges = service.Spec.LoadBalancerSourceRanges
info.onlyNodeLocalEndpoints = apiservice.NeedsHealthCheck(service) && featuregate.DefaultFeatureGate.ExternalTrafficLocalOnly() info.onlyNodeLocalEndpoints = apiservice.NeedsHealthCheck(service) && featuregate.DefaultFeatureGate.ExternalTrafficLocalOnly() && (service.Spec.Type == api.ServiceTypeLoadBalancer || service.Spec.Type == api.ServiceTypeNodePort)
if info.onlyNodeLocalEndpoints { if info.onlyNodeLocalEndpoints {
p := apiservice.GetServiceHealthCheckNodePort(service) p := apiservice.GetServiceHealthCheckNodePort(service)
if p == 0 { if p == 0 {
glog.Errorf("Service does not contain necessary annotation %v", glog.Errorf("Service does not contain necessary annotation %v",
apiservice.AnnotationHealthCheckNodePort) apiservice.AnnotationHealthCheckNodePort)
} else { } else {
glog.V(4).Infof("Adding health check for %+v, port %v", serviceName.NamespacedName, p)
info.healthCheckNodePort = int(p) info.healthCheckNodePort = int(p)
// Turn on healthcheck responder to listen on the health check nodePort // Turn on healthcheck responder to listen on the health check nodePort
healthcheck.AddServiceListener(serviceName.NamespacedName, info.healthCheckNodePort) healthcheck.AddServiceListener(serviceName.NamespacedName, info.healthCheckNodePort)
} }
} else { } else {
glog.V(4).Infof("Deleting health check for %+v", serviceName.NamespacedName)
// Delete healthcheck responders, if any, previously listening for this service // Delete healthcheck responders, if any, previously listening for this service
healthcheck.DeleteServiceListener(serviceName.NamespacedName, 0) healthcheck.DeleteServiceListener(serviceName.NamespacedName, 0)
} }
@ -488,6 +490,7 @@ func (proxier *Proxier) OnServiceUpdate(allServices []api.Service) {
if info.onlyNodeLocalEndpoints && info.healthCheckNodePort > 0 { if info.onlyNodeLocalEndpoints && info.healthCheckNodePort > 0 {
// Remove ServiceListener health check nodePorts from the health checker // Remove ServiceListener health check nodePorts from the health checker
// TODO - Stats // TODO - Stats
glog.V(4).Infof("Deleting health check for %+v, port %v", name.NamespacedName, info.healthCheckNodePort)
healthcheck.DeleteServiceListener(name.NamespacedName, info.healthCheckNodePort) healthcheck.DeleteServiceListener(name.NamespacedName, info.healthCheckNodePort)
} }
} }