From 5d2702b0fd798ec7fc95be0f48f3ce0a0d0112db Mon Sep 17 00:00:00 2001 From: Andrew Sy Kim Date: Wed, 8 Sep 2021 16:15:18 -0400 Subject: [PATCH] core/v1: add comments about why Service internalTrafficPolicy is not forbidden when type is ExternalName Signed-off-by: Andrew Sy Kim --- pkg/apis/core/validation/validation.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/apis/core/validation/validation.go b/pkg/apis/core/validation/validation.go index bc2d46134da..62c42638929 100644 --- a/pkg/apis/core/validation/validation.go +++ b/pkg/apis/core/validation/validation.go @@ -4809,6 +4809,8 @@ func validateServiceInternalTrafficFieldsValue(service *core.Service) field.Erro if utilfeature.DefaultFeatureGate.Enabled(features.ServiceInternalTrafficPolicy) { if service.Spec.InternalTrafficPolicy == nil { + // We do not forbid internalTrafficPolicy on other Service types because of historical reasons. + // We did not check that before it went beta and we don't want to invalidate existing stored objects. if service.Spec.Type == core.ServiceTypeNodePort || service.Spec.Type == core.ServiceTypeLoadBalancer || service.Spec.Type == core.ServiceTypeClusterIP { allErrs = append(allErrs, field.Required(field.NewPath("spec").Child("internalTrafficPolicy"), ""))