From 5d582501b40c02cbfc1c1e4510df9554ce510115 Mon Sep 17 00:00:00 2001 From: Janet Kuo Date: Thu, 9 Jun 2016 17:09:54 -0700 Subject: [PATCH] Add unit test for deployment strategy validation --- pkg/apis/extensions/validation/validation_test.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pkg/apis/extensions/validation/validation_test.go b/pkg/apis/extensions/validation/validation_test.go index c019f3ed1ac..40c12250792 100644 --- a/pkg/apis/extensions/validation/validation_test.go +++ b/pkg/apis/extensions/validation/validation_test.go @@ -547,6 +547,13 @@ func validDeployment() *extensions.Deployment { "name": "abc", }, }, + Strategy: extensions.DeploymentStrategy{ + Type: extensions.RollingUpdateDeploymentStrategyType, + RollingUpdate: &extensions.RollingUpdateDeployment{ + MaxSurge: intstr.FromInt(1), + MaxUnavailable: intstr.FromInt(1), + }, + }, Template: api.PodTemplateSpec{ ObjectMeta: api.ObjectMeta{ Name: "abc", @@ -604,6 +611,11 @@ func TestValidateDeployment(t *testing.T) { invalidRestartPolicyDeployment.Spec.Template.Spec.RestartPolicy = api.RestartPolicyNever errorCases["Unsupported value: \"Never\""] = invalidRestartPolicyDeployment + // must have valid strategy type + invalidStrategyDeployment := validDeployment() + invalidStrategyDeployment.Spec.Strategy.Type = extensions.DeploymentStrategyType("randomType") + errorCases["supported values: Recreate, RollingUpdate"] = invalidStrategyDeployment + // rollingUpdate should be nil for recreate. invalidRecreateDeployment := validDeployment() invalidRecreateDeployment.Spec.Strategy = extensions.DeploymentStrategy{