From 5e0161b3de889b94961cf1950a1e4c66c29927bc Mon Sep 17 00:00:00 2001
From: Qirui <qiruiluo2022@u.northwestern.edu>
Date: Mon, 20 Mar 2023 13:06:56 +0800
Subject: [PATCH] Chore: add labels tweak function

---
 pkg/apis/apps/validation/validation_test.go | 27 +++++++++------------
 1 file changed, 12 insertions(+), 15 deletions(-)

diff --git a/pkg/apis/apps/validation/validation_test.go b/pkg/apis/apps/validation/validation_test.go
index c2d1605b725..142dca6b94a 100644
--- a/pkg/apis/apps/validation/validation_test.go
+++ b/pkg/apis/apps/validation/validation_test.go
@@ -74,6 +74,15 @@ func tweakNamespace(ns string) statefulSetTweak {
 	}
 }
 
+func tweakLabels(key string, value string) statefulSetTweak {
+	return func(ss *apps.StatefulSet) {
+		if ss.ObjectMeta.Labels == nil {
+			ss.ObjectMeta.Labels = map[string]string{}
+		}
+		ss.ObjectMeta.Labels[key] = value
+	}
+}
+
 func tweakAnnotations(key string, value string) statefulSetTweak {
 	return func(ss *apps.StatefulSet) {
 		if ss.ObjectMeta.Annotations == nil {
@@ -315,21 +324,9 @@ func TestValidateStatefulSet(t *testing.T) {
 		},
 		{
 			name: "invalid_label",
-			set: apps.StatefulSet{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "abc-123",
-					Namespace: metav1.NamespaceDefault,
-					Labels: map[string]string{
-						"NoUppercaseOrSpecialCharsLike=Equals": "bar",
-					},
-				},
-				Spec: apps.StatefulSetSpec{
-					PodManagementPolicy: apps.OrderedReadyPodManagement,
-					Selector:            &metav1.LabelSelector{MatchLabels: validLabels},
-					Template:            validPodTemplate.Template,
-					UpdateStrategy:      apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType},
-				},
-			},
+			set: mkStatefulSet(&validPodTemplate,
+				tweakLabels("NoUppercaseOrSpecialCharsLike=Equals", "bar"),
+			),
 			errs: field.ErrorList{
 				field.Invalid(field.NewPath("metadata", "labels"), nil, ""),
 			},