From 1bb76633dacc130bf4863588858536aff7f6b57b Mon Sep 17 00:00:00 2001 From: Alex Robinson Date: Thu, 30 Apr 2015 14:56:02 -0700 Subject: [PATCH] Make hack/test-go.sh friendlier to OS X bash by not using a -1 array index. Without this, everytime I run test-go.sh I get the following error: ./hack/test-go.sh: line 215: apiVersions: bad array subscript --- hack/test-go.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hack/test-go.sh b/hack/test-go.sh index ddac88fe34c..5b7499318db 100755 --- a/hack/test-go.sh +++ b/hack/test-go.sh @@ -207,12 +207,14 @@ reportCoverageToCoveralls() { # Convert the CSV to an array of API versions to test IFS=',' read -a apiVersions <<< "${KUBE_TEST_API_VERSIONS}" ETCD_PREFIX=${ETCD_STANDARD_PREFIX} +LAST_API_VERSION="" for apiVersion in "${apiVersions[@]}"; do echo "Running tests for APIVersion: $apiVersion" + LAST_API_VERSION=$apiVersion KUBE_API_VERSION="${apiVersion}" ETCD_PREFIX=${ETCD_STANDARD_PREFIX} runTests "$@" done echo "Using custom etcd path prefix: ${ETCD_CUSTOM_PREFIX}" -KUBE_API_VERSION="${apiVersions[-1]}" ETCD_PREFIX=${ETCD_CUSTOM_PREFIX} runTests "$@" +KUBE_API_VERSION="${LAST_API_VERSION}" ETCD_PREFIX=${ETCD_CUSTOM_PREFIX} runTests "$@" # We might run the tests for multiple versions, but we want to report only # one of them to coveralls. Here we report coverage from the last run.