From 5f4d646ea33b33a078908228bc857b705a636f14 Mon Sep 17 00:00:00 2001 From: Lionel Jouin Date: Sun, 29 Dec 2024 12:29:58 +0100 Subject: [PATCH] Add Device status const comments Signed-off-by: Lionel Jouin --- pkg/apis/resource/types.go | 18 ++++++++++++++---- .../src/k8s.io/api/resource/v1alpha3/types.go | 18 ++++++++++++++---- .../src/k8s.io/api/resource/v1beta1/types.go | 18 ++++++++++++++---- 3 files changed, 42 insertions(+), 12 deletions(-) diff --git a/pkg/apis/resource/types.go b/pkg/apis/resource/types.go index c2c62f14132..44c4d3f863b 100644 --- a/pkg/apis/resource/types.go +++ b/pkg/apis/resource/types.go @@ -989,10 +989,20 @@ type ResourceClaimTemplateList struct { } const ( - AllocatedDeviceStatusMaxConditions int = 8 - AllocatedDeviceStatusDataMaxLength int = OpaqueParametersMaxLength - NetworkDeviceDataMaxIPs int = 16 - NetworkDeviceDataInterfaceNameMaxLength int = 256 + // AllocatedDeviceStatusMaxConditions represents the maximum number of + // conditions in a device status. + AllocatedDeviceStatusMaxConditions int = 8 + // AllocatedDeviceStatusDataMaxLength represents the maximum length of the + // raw data in the Data field in a device status. + AllocatedDeviceStatusDataMaxLength int = 10 * 1024 + // NetworkDeviceDataMaxIPs represents the maximum number of IPs in the networkData + // field in a device status. + NetworkDeviceDataMaxIPs int = 16 + // NetworkDeviceDataInterfaceNameMaxLength represents the maximum number of characters + // for the networkData.interfaceName field in a device status. + NetworkDeviceDataInterfaceNameMaxLength int = 256 + // NetworkDeviceDataHardwareAddressMaxLength represents the maximum number of characters + // for the networkData.hardwareAddress field in a device status. NetworkDeviceDataHardwareAddressMaxLength int = 128 ) diff --git a/staging/src/k8s.io/api/resource/v1alpha3/types.go b/staging/src/k8s.io/api/resource/v1alpha3/types.go index 9e47bf061be..72d9d13049f 100644 --- a/staging/src/k8s.io/api/resource/v1alpha3/types.go +++ b/staging/src/k8s.io/api/resource/v1alpha3/types.go @@ -1000,10 +1000,20 @@ type ResourceClaimTemplateList struct { } const ( - AllocatedDeviceStatusMaxConditions int = 8 - AllocatedDeviceStatusDataMaxLength int = OpaqueParametersMaxLength - NetworkDeviceDataMaxIPs int = 16 - NetworkDeviceDataInterfaceNameMaxLength int = 256 + // AllocatedDeviceStatusMaxConditions represents the maximum number of + // conditions in a device status. + AllocatedDeviceStatusMaxConditions int = 8 + // AllocatedDeviceStatusDataMaxLength represents the maximum length of the + // raw data in the Data field in a device status. + AllocatedDeviceStatusDataMaxLength int = 10 * 1024 + // NetworkDeviceDataMaxIPs represents the maximum number of IPs in the networkData + // field in a device status. + NetworkDeviceDataMaxIPs int = 16 + // NetworkDeviceDataInterfaceNameMaxLength represents the maximum number of characters + // for the networkData.interfaceName field in a device status. + NetworkDeviceDataInterfaceNameMaxLength int = 256 + // NetworkDeviceDataHardwareAddressMaxLength represents the maximum number of characters + // for the networkData.hardwareAddress field in a device status. NetworkDeviceDataHardwareAddressMaxLength int = 128 ) diff --git a/staging/src/k8s.io/api/resource/v1beta1/types.go b/staging/src/k8s.io/api/resource/v1beta1/types.go index 71c0cb87adc..67ea9f749a7 100644 --- a/staging/src/k8s.io/api/resource/v1beta1/types.go +++ b/staging/src/k8s.io/api/resource/v1beta1/types.go @@ -1003,10 +1003,20 @@ type ResourceClaimTemplateList struct { } const ( - AllocatedDeviceStatusMaxConditions int = 8 - AllocatedDeviceStatusDataMaxLength int = OpaqueParametersMaxLength - NetworkDeviceDataMaxIPs int = 16 - NetworkDeviceDataInterfaceNameMaxLength int = 256 + // AllocatedDeviceStatusMaxConditions represents the maximum number of + // conditions in a device status. + AllocatedDeviceStatusMaxConditions int = 8 + // AllocatedDeviceStatusDataMaxLength represents the maximum length of the + // raw data in the Data field in a device status. + AllocatedDeviceStatusDataMaxLength int = 10 * 1024 + // NetworkDeviceDataMaxIPs represents the maximum number of IPs in the networkData + // field in a device status. + NetworkDeviceDataMaxIPs int = 16 + // NetworkDeviceDataInterfaceNameMaxLength represents the maximum number of characters + // for the networkData.interfaceName field in a device status. + NetworkDeviceDataInterfaceNameMaxLength int = 256 + // NetworkDeviceDataHardwareAddressMaxLength represents the maximum number of characters + // for the networkData.hardwareAddress field in a device status. NetworkDeviceDataHardwareAddressMaxLength int = 128 )