From 5f5897798efe3f3f69a536c3126b3cafc3a0ff57 Mon Sep 17 00:00:00 2001 From: Han Kang Date: Mon, 26 Sep 2022 09:13:41 -0700 Subject: [PATCH] add unit test coverage Change-Id: Idfbc9e72f1e0051a9423b23d1f0397364bb3c251 --- .../component-base/featuregate/feature_gate_test.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/component-base/featuregate/feature_gate_test.go b/staging/src/k8s.io/component-base/featuregate/feature_gate_test.go index 042356f61f7..1ff8a9ff781 100644 --- a/staging/src/k8s.io/component-base/featuregate/feature_gate_test.go +++ b/staging/src/k8s.io/component-base/featuregate/feature_gate_test.go @@ -429,22 +429,29 @@ func TestFeatureGateMetrics(t *testing.T) { featuremetrics.ResetFeatureInfoMetric() const testAlphaGate Feature = "TestAlpha" const testBetaGate Feature = "TestBeta" + const testAlphaEnabled Feature = "TestAlphaEnabled" + const testBetaDisabled Feature = "TestBetaDisabled" testedMetrics := []string{"kubernetes_feature_enabled"} expectedOutput := ` # HELP kubernetes_feature_enabled [ALPHA] This metric records the data about the stage and enablement of a k8s feature. # TYPE kubernetes_feature_enabled gauge kubernetes_feature_enabled{name="TestAlpha",stage="ALPHA"} 0 kubernetes_feature_enabled{name="TestBeta",stage="BETA"} 1 + kubernetes_feature_enabled{name="TestAlphaEnabled",stage="ALPHA"} 1 kubernetes_feature_enabled{name="AllAlpha",stage="ALPHA"} 0 kubernetes_feature_enabled{name="AllBeta",stage="BETA"} 0 + kubernetes_feature_enabled{name="TestBetaDisabled",stage="ALPHA"} 0 ` f := NewFeatureGate() fMap := map[Feature]FeatureSpec{ - testAlphaGate: {Default: false, PreRelease: Alpha}, - testBetaGate: {Default: true, PreRelease: Beta}, + testAlphaGate: {Default: false, PreRelease: Alpha}, + testAlphaEnabled: {Default: false, PreRelease: Alpha}, + testBetaGate: {Default: true, PreRelease: Beta}, + testBetaDisabled: {Default: true, PreRelease: Alpha}, } f.Add(fMap) + f.SetFromMap(map[string]bool{"TestAlphaEnabled": true, "TestBetaDisabled": false}) f.AddMetrics() if err := testutil.GatherAndCompare(legacyregistry.DefaultGatherer, strings.NewReader(expectedOutput), testedMetrics...); err != nil { t.Fatal(err)