github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-19 09:52:49 +00:00
Code Issues Projects Releases Wiki Activity

flaky test wait.sh: Add deployment assertion before running wait

Browse Source 
There is a test in wait.sh integration suite which is checking the
given timeout value(passed by user) is equal to actual happened timeout value.

However, this test rarely gets `no matching resources found` error and
causes flakyiness. The reason is we are running wait command, immediately
after applying deployment. In reality, timeout test does not care about
deployment, since it is testing the timeout by passing invalid configurations.
But we need this deployment to not get `no matching resources found` error.

That's why, this PR adds deployment assertion before executing wait command.
This commit is contained in:
Arda Güçlü 2023-02-07 14:19:34 +03:00
parent 8e20effbb7
commit 60401d35d1
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/cmd/wait.sh
View File

@ -78,6 +78,9 @@ spec:
command: ["/bin/sh", "-c", "sleep infinity"] command: ["/bin/sh", "-c", "sleep infinity"]
EOF EOF
# Make sure deployment is successfully applied
kube::test::wait_object_assert deployments "{{range.items}}{{${id_field:?}}}{{end}}" 'dtest'
set +o errexit set +o errexit
# wait timeout error because condition is invalid # wait timeout error because condition is invalid
start_sec=$(date +"%s") start_sec=$(date +"%s")