From b4ea59e65a63d053989da131768a4623dd92fea7 Mon Sep 17 00:00:00 2001 From: "Madhusudan.C.S" Date: Thu, 11 Aug 2016 00:22:00 -0700 Subject: [PATCH] Update dnsprovider multi-type support test to test for an A-record and an AAAA-record. Having an A-record and a CNAME-record in the tests led to a confusion that dns providers support such configurations. This change avoids that confusion by putting only compatible records for the same domain name in the tests. --- federation/pkg/dnsprovider/rrstype/rrstype.go | 1 + federation/pkg/dnsprovider/tests/commontests.go | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/federation/pkg/dnsprovider/rrstype/rrstype.go b/federation/pkg/dnsprovider/rrstype/rrstype.go index e8f274ec8be..acf9e90b312 100644 --- a/federation/pkg/dnsprovider/rrstype/rrstype.go +++ b/federation/pkg/dnsprovider/rrstype/rrstype.go @@ -22,6 +22,7 @@ type ( const ( A = RrsType("A") + AAAA = RrsType("AAAA") CNAME = RrsType("CNAME") // TODO: Add other types as required ) diff --git a/federation/pkg/dnsprovider/tests/commontests.go b/federation/pkg/dnsprovider/tests/commontests.go index 900a5bbc26c..7527a956a08 100644 --- a/federation/pkg/dnsprovider/tests/commontests.go +++ b/federation/pkg/dnsprovider/tests/commontests.go @@ -84,17 +84,17 @@ func CommonTestResourceRecordSetsDifferentTypes(t *testing.T, zone dnsprovider.Z defer sets.StartChangeset().Remove(rrset).Apply() t.Logf("Successfully added resource record set: %v", rrset) - cnameRrset := rrsets.New("alpha.test.com", []string{"cname.test.com"}, 80, rrstype.CNAME) + aaaaRrset := rrsets.New("alpha.test.com", []string{"2001:4860:4860::8888"}, 80, rrstype.AAAA) // Add the resource with the same name but different type - err := sets.StartChangeset().Add(cnameRrset).Apply() + err := sets.StartChangeset().Add(aaaaRrset).Apply() if err != nil { - t.Errorf("Failed to add resource record set %v: %v", cnameRrset, err) + t.Errorf("Failed to add resource record set %v: %v", aaaaRrset, err) } - defer sets.StartChangeset().Remove(cnameRrset).Apply() + defer sets.StartChangeset().Remove(aaaaRrset).Apply() // Check that both records exist - assertHasRecord(t, sets, cnameRrset) + assertHasRecord(t, sets, aaaaRrset) assertHasRecord(t, sets, rrset) }