From 6bd0a7d6a9c31b16ad2d5aa18f51702ea6393f82 Mon Sep 17 00:00:00 2001 From: dmathieu <42@dmathieu.com> Date: Wed, 7 Feb 2018 09:48:11 +0100 Subject: [PATCH] remove method NewCronJobControllerFromClient This method was originally introduced when cronjob was still called scheduledjob: https://github.com/kubernetes/kubernetes/commit/7a34347f7f7503dea787c6cb0f27c5e97b1c49d2 Back then, both init methods had different signatures. Since the rename to cronjob (https://github.com/kubernetes/kubernetes/commit/41d88d30ddbec0f06bc82bf087a85dfcc030db79), this method is an alias to the normal initializer, have the same signature and is not used anywhere in the codebase. Since this method was never actually used for cronjobs, it doesn't seem removing it would need any deprecation notice. --- pkg/controller/cronjob/cronjob_controller.go | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pkg/controller/cronjob/cronjob_controller.go b/pkg/controller/cronjob/cronjob_controller.go index 679895e85df..5a863a00983 100644 --- a/pkg/controller/cronjob/cronjob_controller.go +++ b/pkg/controller/cronjob/cronjob_controller.go @@ -89,14 +89,6 @@ func NewCronJobController(kubeClient clientset.Interface) (*CronJobController, e return jm, nil } -func NewCronJobControllerFromClient(kubeClient clientset.Interface) (*CronJobController, error) { - jm, err := NewCronJobController(kubeClient) - if err != nil { - return nil, err - } - return jm, nil -} - // Run the main goroutine responsible for watching and syncing jobs. func (jm *CronJobController) Run(stopCh <-chan struct{}) { defer utilruntime.HandleCrash()