github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Test failed pod recreation

Browse Source 
Change-Id: I31a2e667e9d96c385a921e25347ebeb5a8424e62
This commit is contained in:
Aldo Culquicondor 2021-02-01 13:20:03 -05:00
parent dbf9e3b2d3
commit 609116b147
1 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
pkg/controller/job/job_controller_test.go
View File

@ -267,7 +267,17 @@ func TestControllerSyncJob(t *testing.T) {
expectedSucceeded: 1, expectedSucceeded: 1,
expectedFailed: 1, expectedFailed: 1,
}, },
"only new failed pod": { "new failed pod": {
parallelism: 2,
completions: 5,
backoffLimit: 6,
activePods: 1,
failedPods: 1,
expectedCreations: 1,
expectedActive: 2,
expectedFailed: 1,
},
"only new failed pod with controller error": {
parallelism: 2, parallelism: 2,
completions: 5, completions: 5,
backoffLimit: 6, backoffLimit: 6,
@ -399,12 +409,18 @@ func TestControllerSyncJob(t *testing.T) {
// We need requeue syncJob task if podController error // We need requeue syncJob task if podController error
if tc.podControllerError != nil { if tc.podControllerError != nil {
if err == nil { if err == nil {
t.Errorf("Syncing jobs would return error when podController exception") t.Error("Syncing jobs expected to return error on podControl exception")
} }
} else { } else if tc.failedPods > 0 && tc.expectedCondition == nil {
if err != nil && (tc.podLimit == 0 || fakePodControl.CreateCallCount < tc.podLimit) { if err == nil {
t.Errorf("Unexpected error when syncing jobs: %v", err) t.Error("Syncing jobs expected to return error when there are new failed pods and Job didn't finish")
} }
} else if tc.podLimit != 0 && fakePodControl.CreateCallCount > tc.podLimit {
if err == nil {
t.Error("Syncing jobs expected to return error when reached the podControl limit")
}
} else if err != nil {
t.Errorf("Unexpected error when syncing jobs: %v", err)
} }
if forget != tc.jobKeyForget { if forget != tc.jobKeyForget {
t.Errorf("Unexpected forget value. Expected %v, saw %v\n", tc.jobKeyForget, forget) t.Errorf("Unexpected forget value. Expected %v, saw %v\n", tc.jobKeyForget, forget)