From 9a3148291d499a7dc8e25caf429a9a7a8ac06a56 Mon Sep 17 00:00:00 2001
From: Chok Yip Lau <lauchokyip@gmail.com>
Date: Sat, 9 Jan 2021 19:51:51 -0500
Subject: [PATCH] Fix golint errors for
 kubectl/pkg/cmd/certificates/certificates.go

---
 hack/.golint_failures                                  |  1 -
 .../kubectl/pkg/cmd/certificates/certificates.go       | 10 +++++++++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/hack/.golint_failures b/hack/.golint_failures
index bbe9d9a693b..531b41a8550 100644
--- a/hack/.golint_failures
+++ b/hack/.golint_failures
@@ -413,7 +413,6 @@ staging/src/k8s.io/kubectl/pkg/cmd/annotate
 staging/src/k8s.io/kubectl/pkg/cmd/apply
 staging/src/k8s.io/kubectl/pkg/cmd/attach
 staging/src/k8s.io/kubectl/pkg/cmd/autoscale
-staging/src/k8s.io/kubectl/pkg/cmd/certificates
 staging/src/k8s.io/kubectl/pkg/cmd/clusterinfo
 staging/src/k8s.io/kubectl/pkg/cmd/create
 staging/src/k8s.io/kubectl/pkg/cmd/debug
diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/certificates/certificates.go b/staging/src/k8s.io/kubectl/pkg/cmd/certificates/certificates.go
index 08fc609818f..d7caefe33da 100644
--- a/staging/src/k8s.io/kubectl/pkg/cmd/certificates/certificates.go
+++ b/staging/src/k8s.io/kubectl/pkg/cmd/certificates/certificates.go
@@ -41,6 +41,7 @@ import (
 	"k8s.io/kubectl/pkg/util/templates"
 )
 
+// NewCmdCertificate returns `certificate` Cobra command
 func NewCmdCertificate(f cmdutil.Factory, ioStreams genericclioptions.IOStreams) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:                   "certificate SUBCOMMAND",
@@ -58,6 +59,7 @@ func NewCmdCertificate(f cmdutil.Factory, ioStreams genericclioptions.IOStreams)
 	return cmd
 }
 
+// CertificateOptions declares the arguments accepted by the certificate command
 type CertificateOptions struct {
 	resource.FilenameOptions
 
@@ -73,7 +75,7 @@ type CertificateOptions struct {
 	genericclioptions.IOStreams
 }
 
-// NewCertificateOptions creates the options for certificate
+// NewCertificateOptions creates CertificateOptions struct for `certificate` command
 func NewCertificateOptions(ioStreams genericclioptions.IOStreams, operation string) *CertificateOptions {
 	return &CertificateOptions{
 		PrintFlags: genericclioptions.NewPrintFlags(operation).WithTypeSetter(scheme.Scheme),
@@ -81,6 +83,7 @@ func NewCertificateOptions(ioStreams genericclioptions.IOStreams, operation stri
 	}
 }
 
+// Complete loads data from the command environment
 func (o *CertificateOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args []string) error {
 	o.csrNames = args
 	o.outputStyle = cmdutil.GetFlagString(cmd, "output")
@@ -104,6 +107,7 @@ func (o *CertificateOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, arg
 	return nil
 }
 
+// Validate checks if the provided `certificate` arguments are valid
 func (o *CertificateOptions) Validate() error {
 	if len(o.csrNames) < 1 && cmdutil.IsFilenameSliceEmpty(o.Filenames, o.Kustomize) {
 		return fmt.Errorf("one or more CSRs must be specified as <name> or -f <filename>")
@@ -111,6 +115,7 @@ func (o *CertificateOptions) Validate() error {
 	return nil
 }
 
+// NewCmdCertificateApprove returns the `certificate approve` Cobra command
 func NewCmdCertificateApprove(f cmdutil.Factory, ioStreams genericclioptions.IOStreams) *cobra.Command {
 	o := NewCertificateOptions(ioStreams, "approved")
 
@@ -145,6 +150,7 @@ func NewCmdCertificateApprove(f cmdutil.Factory, ioStreams genericclioptions.IOS
 	return cmd
 }
 
+// RunCertificateApprove approves a certificate signing request
 func (o *CertificateOptions) RunCertificateApprove(force bool) error {
 	return o.modifyCertificateCondition(
 		o.builder,
@@ -154,6 +160,7 @@ func (o *CertificateOptions) RunCertificateApprove(force bool) error {
 	)
 }
 
+// NewCmdCertificateDeny returns the `certificate deny` Cobra command
 func NewCmdCertificateDeny(f cmdutil.Factory, ioStreams genericclioptions.IOStreams) *cobra.Command {
 	o := NewCertificateOptions(ioStreams, "denied")
 
@@ -183,6 +190,7 @@ func NewCmdCertificateDeny(f cmdutil.Factory, ioStreams genericclioptions.IOStre
 	return cmd
 }
 
+// RunCertificateDeny denies a certificate signing request
 func (o *CertificateOptions) RunCertificateDeny(force bool) error {
 	return o.modifyCertificateCondition(
 		o.builder,