github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #28441 from smarterclayton/reflect_check

Browse Source 
Automatic merge from submit-queue

ObjectReflectDiff has an incorrect array index comparison

Is comparing the wrong field for bounds.

@deads2k
This commit is contained in:
k8s-merge-robot 2016-07-05 05:33:28 -07:00 committed by GitHub
commit 61a92ef75a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/util/diff/diff.go
View File

@ -177,10 +177,10 @@ func objectReflectDiff(path *field.Path, a, b reflect.Value) []diff {
} }
} }
var diffs []diff var diffs []diff
for i := l; l < lA; i++ { for i := l; i < lA; i++ {
diffs = append(diffs, diff{path: path.Index(i), a: a.Index(i), b: nil}) diffs = append(diffs, diff{path: path.Index(i), a: a.Index(i), b: nil})
} }
for i := l; l < lB; i++ { for i := l; i < lB; i++ {
diffs = append(diffs, diff{path: path.Index(i), a: nil, b: b.Index(i)}) diffs = append(diffs, diff{path: path.Index(i), a: nil, b: b.Index(i)})
} }
return diffs return diffs