From 61c9dd876e25a872f730313b9d355b663d2cbe51 Mon Sep 17 00:00:00 2001 From: Karl Isenberg Date: Thu, 13 Aug 2015 12:06:01 -0700 Subject: [PATCH] Improve readability of scheduling failure logs --- contrib/mesos/pkg/scheduler/plugin.go | 6 +++--- plugin/pkg/scheduler/scheduler.go | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/contrib/mesos/pkg/scheduler/plugin.go b/contrib/mesos/pkg/scheduler/plugin.go index c353165f7e6..b2ba6b132e2 100644 --- a/contrib/mesos/pkg/scheduler/plugin.go +++ b/contrib/mesos/pkg/scheduler/plugin.go @@ -754,10 +754,10 @@ func (s *schedulingPlugin) Run(done <-chan struct{}) { // with the Modeler stuff removed since we don't use it because we have mesos. func (s *schedulingPlugin) scheduleOne() { pod := s.config.NextPod() - log.V(3).Infof("Attempting to schedule: %v", pod) + log.V(3).Infof("Attempting to schedule: %+v", pod) dest, err := s.config.Algorithm.Schedule(pod, s.config.MinionLister) // call kubeScheduler.Schedule if err != nil { - log.V(1).Infof("Failed to schedule: %v", pod) + log.V(1).Infof("Failed to schedule: %+v", pod) s.config.Recorder.Eventf(pod, "FailedScheduling", "Error scheduling: %v", err) s.config.Error(pod, err) return @@ -770,7 +770,7 @@ func (s *schedulingPlugin) scheduleOne() { }, } if err := s.config.Binder.Bind(b); err != nil { - log.V(1).Infof("Failed to bind pod: %v", err) + log.V(1).Infof("Failed to bind pod: %+v", err) s.config.Recorder.Eventf(pod, "FailedScheduling", "Binding rejected: %v", err) s.config.Error(pod, err) return diff --git a/plugin/pkg/scheduler/scheduler.go b/plugin/pkg/scheduler/scheduler.go index 26abe5ce66c..26d6be414df 100644 --- a/plugin/pkg/scheduler/scheduler.go +++ b/plugin/pkg/scheduler/scheduler.go @@ -116,7 +116,7 @@ func (s *Scheduler) scheduleOne() { s.config.BindPodsRateLimiter.Accept() } - glog.V(3).Infof("Attempting to schedule: %v", pod) + glog.V(3).Infof("Attempting to schedule: %+v", pod) start := time.Now() defer func() { metrics.E2eSchedulingLatency.Observe(metrics.SinceInMicroseconds(start)) @@ -124,7 +124,7 @@ func (s *Scheduler) scheduleOne() { dest, err := s.config.Algorithm.Schedule(pod, s.config.MinionLister) metrics.SchedulingAlgorithmLatency.Observe(metrics.SinceInMicroseconds(start)) if err != nil { - glog.V(1).Infof("Failed to schedule: %v", pod) + glog.V(1).Infof("Failed to schedule: %+v", pod) s.config.Recorder.Eventf(pod, "FailedScheduling", "%v", err) s.config.Error(pod, err) return @@ -144,7 +144,7 @@ func (s *Scheduler) scheduleOne() { err := s.config.Binder.Bind(b) metrics.BindingLatency.Observe(metrics.SinceInMicroseconds(bindingStart)) if err != nil { - glog.V(1).Infof("Failed to bind pod: %v", err) + glog.V(1).Infof("Failed to bind pod: %+v", err) s.config.Recorder.Eventf(pod, "FailedScheduling", "Binding rejected: %v", err) s.config.Error(pod, err) return