From 61fa4e6c098559b65fe28c1bf55cb817697e38e5 Mon Sep 17 00:00:00 2001 From: Jefftree Date: Thu, 27 Feb 2020 17:18:57 -0800 Subject: [PATCH] Address comment and remove if condition --- staging/src/k8s.io/apiserver/pkg/server/options/audit.go | 1 - staging/src/k8s.io/apiserver/pkg/util/webhook/BUILD | 1 + staging/src/k8s.io/apiserver/pkg/util/webhook/webhook.go | 4 +--- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/server/options/audit.go b/staging/src/k8s.io/apiserver/pkg/server/options/audit.go index 090ef5a2b50..8a3503cab36 100644 --- a/staging/src/k8s.io/apiserver/pkg/server/options/audit.go +++ b/staging/src/k8s.io/apiserver/pkg/server/options/audit.go @@ -325,7 +325,6 @@ func (o *AuditOptions) ApplyTo( if checker == nil { klog.V(2).Info("No audit policy file provided, no events will be recorded for webhook backend") } else { - if c.EgressSelector != nil { egressDialer, err := c.EgressSelector.Lookup(egressselector.Master.AsNetworkContext()) if err != nil { diff --git a/staging/src/k8s.io/apiserver/pkg/util/webhook/BUILD b/staging/src/k8s.io/apiserver/pkg/util/webhook/BUILD index d8b20370007..91717516b83 100644 --- a/staging/src/k8s.io/apiserver/pkg/util/webhook/BUILD +++ b/staging/src/k8s.io/apiserver/pkg/util/webhook/BUILD @@ -29,6 +29,7 @@ go_library( "//staging/src/k8s.io/apimachinery/pkg/util/validation:go_default_library", "//staging/src/k8s.io/apimachinery/pkg/util/validation/field:go_default_library", "//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library", + "//staging/src/k8s.io/apiserver/pkg/server/egressselector:go_default_library", "//staging/src/k8s.io/client-go/rest:go_default_library", "//staging/src/k8s.io/client-go/tools/clientcmd:go_default_library", "//staging/src/k8s.io/client-go/tools/clientcmd/api:go_default_library", diff --git a/staging/src/k8s.io/apiserver/pkg/util/webhook/webhook.go b/staging/src/k8s.io/apiserver/pkg/util/webhook/webhook.go index 1ac14fb00b6..f067466afaa 100644 --- a/staging/src/k8s.io/apiserver/pkg/util/webhook/webhook.go +++ b/staging/src/k8s.io/apiserver/pkg/util/webhook/webhook.go @@ -96,9 +96,7 @@ func newGenericWebhook(scheme *runtime.Scheme, codecFactory serializer.CodecFact codec := codecFactory.LegacyCodec(groupVersions...) clientConfig.ContentConfig.NegotiatedSerializer = serializer.NegotiatedSerializerWrapper(runtime.SerializerInfo{Serializer: codec}) - if customDial != nil { - clientConfig.Dial = customDial - } + clientConfig.Dial = customDial restClient, err := rest.UnversionedRESTClientFor(clientConfig) if err != nil {