github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #98110 from dougsland/krunImageName

Browse Source 
kubectl: run - remove unneeded vars
This commit is contained in:
Kubernetes Prow Robot 2021-01-20 08:46:00 -08:00 committed by GitHub
commit 6206f00aa7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
staging/src/k8s.io/kubectl/pkg/cmd/run/run.go
View File

@ -273,13 +273,12 @@ func (o *RunOptions) Run(f cmdutil.Factory, cmd *cobra.Command, args []string) e
} }
// validate image name // validate image name
imageName := o.Image if o.Image == "" {
if imageName == "" {
return fmt.Errorf("--image is required") return fmt.Errorf("--image is required")
} }
validImageRef := reference.ReferenceRegexp.MatchString(imageName)
if !validImageRef { if !reference.ReferenceRegexp.MatchString(o.Image) {
return fmt.Errorf("Invalid image name %q: %v", imageName, reference.ErrReferenceInvalidFormat) return fmt.Errorf("Invalid image name %q: %v", o.Image, reference.ErrReferenceInvalidFormat)
} }
if o.TTY && !o.Interactive { if o.TTY && !o.Interactive {