From 6240febf4c58ddee3647434d3279db26795d59cb Mon Sep 17 00:00:00 2001 From: Swati Sehgal Date: Fri, 17 Jan 2025 11:49:51 +0000 Subject: [PATCH] node:memory-mgr: Add logs on the happy path We have reasonable amount of logs when things go wrong. While debugging, it can be useful to have logs to indicate that things have gone as expected especially when it comes to important events like successful startup of memory manager and successful allocation of resources. Signed-off-by: Swati Sehgal --- pkg/kubelet/cm/memorymanager/memory_manager.go | 1 + pkg/kubelet/cm/memorymanager/policy_static.go | 1 + 2 files changed, 2 insertions(+) diff --git a/pkg/kubelet/cm/memorymanager/memory_manager.go b/pkg/kubelet/cm/memorymanager/memory_manager.go index eb0821869f8..996ac951326 100644 --- a/pkg/kubelet/cm/memorymanager/memory_manager.go +++ b/pkg/kubelet/cm/memorymanager/memory_manager.go @@ -205,6 +205,7 @@ func (m *manager) Start(activePods ActivePodsFunc, sourcesReady config.SourcesRe m.allocatableMemory = m.policy.GetAllocatableMemory(m.state) + klog.V(4).InfoS("memorymanager started", "policy", m.policy.Name()) return nil } diff --git a/pkg/kubelet/cm/memorymanager/policy_static.go b/pkg/kubelet/cm/memorymanager/policy_static.go index bfe704a1f8d..62db4bdc1d0 100644 --- a/pkg/kubelet/cm/memorymanager/policy_static.go +++ b/pkg/kubelet/cm/memorymanager/policy_static.go @@ -196,6 +196,7 @@ func (p *staticPolicy) Allocate(s state.State, pod *v1.Pod, container *v1.Contai // TODO: we should refactor our state structs to reflect the amount of the re-used memory p.updateInitContainersMemoryBlocks(s, pod, container, containerBlocks) + klog.V(4).InfoS("Allocated exclusive memory", "pod", klog.KObj(pod), "containerName", container.Name) return nil }