From d6d2c5775f1f6e611c92e55c9d8636c527b6ae37 Mon Sep 17 00:00:00 2001 From: Tim Hockin Date: Mon, 9 Oct 2023 10:31:25 -0700 Subject: [PATCH] Set gate SkipReadOnlyValidationGCE to Deprecated This was created as alpha (off by default) but should probably have used the "Deprecated" setting. Changing it now makes it on by default and still disable-able. --- pkg/features/kube_features.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index 2548fe6f2b2..4f99f743210 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -142,7 +142,8 @@ const ( // owner: @mfordjody // alpha: v1.26 // - // Skip validation Enable in next version + // Bypasses obsolete validation that GCP volumes are read-only when used in + // Deployments. SkipReadOnlyValidationGCE featuregate.Feature = "SkipReadOnlyValidationGCE" // owner: @trierra @@ -1000,7 +1001,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS CSIVolumeHealth: {Default: false, PreRelease: featuregate.Alpha}, - SkipReadOnlyValidationGCE: {Default: false, PreRelease: featuregate.Alpha}, + SkipReadOnlyValidationGCE: {Default: true, PreRelease: featuregate.Deprecated}, // remove in 1.31 CloudControllerManagerWebhook: {Default: false, PreRelease: featuregate.Alpha},