Merge pull request #107650 from apelisse/update-managedfields-time-field-description

Update ManagedFields Time description to be more accurate
This commit is contained in:
Kubernetes Prow Robot 2022-02-10 23:32:03 -08:00 committed by GitHub
commit 627465b3c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
40 changed files with 48 additions and 40 deletions

View File

@ -16692,7 +16692,7 @@
},
"time": {
"$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -7158,7 +7158,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -884,7 +884,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -1168,7 +1168,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -4588,7 +4588,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -258,7 +258,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -538,7 +538,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -630,7 +630,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -1165,7 +1165,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -1079,7 +1079,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -1156,7 +1156,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -3814,7 +3814,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -3616,7 +3616,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -669,7 +669,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -561,7 +561,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -717,7 +717,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -707,7 +707,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -663,7 +663,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -663,7 +663,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -1054,7 +1054,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -1054,7 +1054,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -643,7 +643,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -1169,7 +1169,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -622,7 +622,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -636,7 +636,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -622,7 +622,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -716,7 +716,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -1167,7 +1167,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -941,7 +941,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -549,7 +549,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -2018,7 +2018,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -609,7 +609,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -609,7 +609,7 @@
},
"time": {
"$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'"
"description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
}
},
"type": "object"

View File

@ -2203,7 +2203,7 @@ func schema_pkg_apis_meta_v1_ManagedFieldsEntry(ref common.ReferenceCallback) co
},
"time": {
SchemaProps: spec.SchemaProps{
Description: "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'",
Description: "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over.",
Ref: ref("k8s.io/apimachinery/pkg/apis/meta/v1.Time"),
},
},

View File

@ -598,7 +598,11 @@ message ManagedFieldsEntry {
// set because it cannot be automatically converted.
optional string apiVersion = 3;
// Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'
// Time is the timestamp of when the ManagedFields entry was added. The
// timestamp will also be updated if a field is added, the manager
// changes any of the owned fields value or removes a field. The
// timestamp does not update when a field is removed from the entry
// because another manager took it over.
// +optional
optional Time time = 4;

View File

@ -1243,7 +1243,11 @@ type ManagedFieldsEntry struct {
// APIVersion field. It is necessary to track the version of a field
// set because it cannot be automatically converted.
APIVersion string `json:"apiVersion,omitempty" protobuf:"bytes,3,opt,name=apiVersion"`
// Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'
// Time is the timestamp of when the ManagedFields entry was added. The
// timestamp will also be updated if a field is added, the manager
// changes any of the owned fields value or removes a field. The
// timestamp does not update when a field is removed from the entry
// because another manager took it over.
// +optional
Time *Time `json:"time,omitempty" protobuf:"bytes,4,opt,name=time"`

View File

@ -227,7 +227,7 @@ var map_ManagedFieldsEntry = map[string]string{
"manager": "Manager is an identifier of the workflow managing these fields.",
"operation": "Operation is the type of operation which lead to this ManagedFieldsEntry being created. The only valid values for this field are 'Apply' and 'Update'.",
"apiVersion": "APIVersion defines the version of this resource that this field set applies to. The format is \"group/version\" just like the top-level APIVersion field. It is necessary to track the version of a field set because it cannot be automatically converted.",
"time": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'",
"time": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over.",
"fieldsType": "FieldsType is the discriminator for the different fields format and version. There is currently only one possible value: \"FieldsV1\"",
"fieldsV1": "FieldsV1 holds the first JSON version format as described in the \"FieldsV1\" type.",
"subresource": "Subresource is the name of the subresource used to update that object, or empty string if the object was updated through the main resource. The value of this field is used to distinguish between managers, even if they share the same name. For example, a status update will be distinct from a regular update using the same manager name. Note that the APIVersion field is not related to the Subresource field and it always corresponds to the version of the main resource.",

View File

@ -1266,7 +1266,7 @@ func schema_pkg_apis_meta_v1_ManagedFieldsEntry(ref common.ReferenceCallback) co
},
"time": {
SchemaProps: spec.SchemaProps{
Description: "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'",
Description: "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over.",
Ref: ref("k8s.io/apimachinery/pkg/apis/meta/v1.Time"),
},
},

View File

@ -1269,7 +1269,7 @@ func schema_pkg_apis_meta_v1_ManagedFieldsEntry(ref common.ReferenceCallback) co
},
"time": {
SchemaProps: spec.SchemaProps{
Description: "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'",
Description: "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over.",
Ref: ref("k8s.io/apimachinery/pkg/apis/meta/v1.Time"),
},
},

View File

@ -1267,7 +1267,7 @@ func schema_pkg_apis_meta_v1_ManagedFieldsEntry(ref common.ReferenceCallback) co
},
"time": {
SchemaProps: spec.SchemaProps{
Description: "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'",
Description: "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over.",
Ref: ref("k8s.io/apimachinery/pkg/apis/meta/v1.Time"),
},
},