github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 03:57:41 +00:00
Code Issues Projects Releases Wiki Activity

e2e node: fix broken assertion

Browse Source 
It looks like the test or the branch is never executed, because it wouldn't
pass: a []v1.NodeIP is value is never the same as []string. Found by the
upcoming ginkgolinter update.

    ERROR: test/e2e_node/pod_host_ips.go:167:45: ginkgo-linter: use Equal with different types: Comparing []k8s.io/api/core/v1.HostIP with []string; either change the expected value type if possible, or use the BeEquivalentTo() matcher, instead of Equal() (ginkgolinter)
    ERROR: 					gomega.Expect(p.Status.HostIPs).Should(gomega.Equal(nodeIPs))
    ERROR: 					                                       ^
This commit is contained in:
Patrick Ohly 2023-10-24 11:19:03 +02:00
parent d0a5cd16da
commit 6302f01121
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/e2e_node/pod_host_ips.go
View File

@ -158,10 +158,10 @@ var _ = common.SIGDescribe("Dual Stack Host IP [Feature:PodHostIPs]", func() {
framework.ExpectNoError(err) framework.ExpectNoError(err)
for _, node := range nodeList.Items { for _, node := range nodeList.Items {
if node.Name == p.Spec.NodeName { if node.Name == p.Spec.NodeName {
nodeIPs := []string{} nodeIPs := []v1.HostIP{}
for _, address := range node.Status.Addresses { for _, address := range node.Status.Addresses {
if address.Type == v1.NodeInternalIP { if address.Type == v1.NodeInternalIP {
nodeIPs = append(nodeIPs, address.Address) nodeIPs = append(nodeIPs, v1.HostIP{IP: address.Address})
} }
} }
gomega.Expect(p.Status.HostIPs).Should(gomega.Equal(nodeIPs)) gomega.Expect(p.Status.HostIPs).Should(gomega.Equal(nodeIPs))
@ -214,10 +214,10 @@ var _ = common.SIGDescribe("Dual Stack Host IP [Feature:PodHostIPs]", func() {
framework.ExpectNoError(err) framework.ExpectNoError(err)
for _, node := range nodeList.Items { for _, node := range nodeList.Items {
if node.Name == p.Spec.NodeName { if node.Name == p.Spec.NodeName {
nodeIPs := []string{} nodeIPs := []v1.HostIP{}
for _, address := range node.Status.Addresses { for _, address := range node.Status.Addresses {
if address.Type == v1.NodeInternalIP { if address.Type == v1.NodeInternalIP {
nodeIPs = append(nodeIPs, address.Address) nodeIPs = append(nodeIPs, v1.HostIP{IP: address.Address})
} }
} }
gomega.Expect(p.Status.HostIPs).Should(gomega.Equal(nodeIPs)) gomega.Expect(p.Status.HostIPs).Should(gomega.Equal(nodeIPs))