diff --git a/pkg/kubelet/dockertools/docker_manager.go b/pkg/kubelet/dockertools/docker_manager.go index fac7dde9e8c..da5cec98b15 100644 --- a/pkg/kubelet/dockertools/docker_manager.go +++ b/pkg/kubelet/dockertools/docker_manager.go @@ -709,7 +709,7 @@ func (dm *DockerManager) runContainer( SecurityOpt: fmtSecurityOpts, } - updateHostConfig(hc) + updateHostConfig(hc, opts) // Set sysctls if requested if container.Name == PodInfraContainerName { diff --git a/pkg/kubelet/dockertools/docker_manager_linux.go b/pkg/kubelet/dockertools/docker_manager_linux.go index 920c58ae990..333ab4673b8 100644 --- a/pkg/kubelet/dockertools/docker_manager_linux.go +++ b/pkg/kubelet/dockertools/docker_manager_linux.go @@ -23,15 +23,16 @@ import ( dockercontainer "github.com/docker/engine-api/types/container" "k8s.io/kubernetes/pkg/api/v1" + kubecontainer "k8s.io/kubernetes/pkg/kubelet/container" ) // These two functions are OS specific (for now at least) -func updateHostConfig(config *dockercontainer.HostConfig) { +func updateHostConfig(hc *dockercontainer.HostConfig, opts *kubecontainer.RunContainerOptions) { // no-op, there is a windows implementation that is different. } func DefaultMemorySwap() int64 { - return -1 + return 0 } func getContainerIP(container *dockertypes.ContainerJSON) string { diff --git a/pkg/kubelet/dockertools/docker_manager_unsupported.go b/pkg/kubelet/dockertools/docker_manager_unsupported.go index 1a095294a90..ecfe5fce112 100644 --- a/pkg/kubelet/dockertools/docker_manager_unsupported.go +++ b/pkg/kubelet/dockertools/docker_manager_unsupported.go @@ -19,14 +19,15 @@ limitations under the License. package dockertools import ( - "k8s.io/kubernetes/pkg/api/v1" - dockertypes "github.com/docker/engine-api/types" dockercontainer "github.com/docker/engine-api/types/container" + + "k8s.io/kubernetes/pkg/api/v1" + kubecontainer "k8s.io/kubernetes/pkg/kubelet/container" ) // These two functions are OS specific (for now at least) -func updateHostConfig(config *dockercontainer.HostConfig) { +func updateHostConfig(hc *dockercontainer.HostConfig, opts *kubecontainer.RunContainerOptions) { } func DefaultMemorySwap() int64 { diff --git a/pkg/kubelet/dockertools/docker_manager_windows.go b/pkg/kubelet/dockertools/docker_manager_windows.go index 31ba2d6f812..4a9ab80693e 100644 --- a/pkg/kubelet/dockertools/docker_manager_windows.go +++ b/pkg/kubelet/dockertools/docker_manager_windows.go @@ -21,14 +21,15 @@ package dockertools import ( "os" - "k8s.io/kubernetes/pkg/api/v1" - dockertypes "github.com/docker/engine-api/types" dockercontainer "github.com/docker/engine-api/types/container" + + "k8s.io/kubernetes/pkg/api/v1" + kubecontainer "k8s.io/kubernetes/pkg/kubelet/container" ) // These two functions are OS specific (for now at least) -func updateHostConfig(config *dockercontainer.HostConfig) { +func updateHostConfig(hc *dockercontainer.HostConfig, opts *kubecontainer.RunContainerOptions) { // There is no /etc/resolv.conf in Windows, DNS and DNSSearch options would have to be passed to Docker runtime instead hc.DNS = opts.DNS hc.DNSSearch = opts.DNSSearch