From 638da25dd1300502cc702bef97058e7138c258d3 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Mon, 14 Dec 2020 08:56:16 +0100 Subject: [PATCH] Revert "use uncommon ports for e2e network test" This reverts commit be1ed2f43a263912bba425ea53191a76001ebdce. The problem happens when the pod tries to be scheduled, not the service. Also, maybe skipping is not the best idea ... --- test/e2e/framework/network/utils.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/test/e2e/framework/network/utils.go b/test/e2e/framework/network/utils.go index 0d47cfeac7a..e22160abe11 100644 --- a/test/e2e/framework/network/utils.go +++ b/test/e2e/framework/network/utils.go @@ -715,13 +715,6 @@ func (config *NetworkingTestConfig) CreateService(serviceSpec *v1.Service) *v1.S framework.ExpectNoError(err, fmt.Sprintf("Failed to create %s service: %v", serviceSpec.Name, err)) err = WaitForService(config.f.ClientSet, config.Namespace, serviceSpec.Name, true, 5*time.Second, 45*time.Second) - // If the endpoints of the service use HostNetwork: true, they are going to try to bind on the host namespace - // if those ports are in use by any process in the host, the endpoints pods will fail to be deployed - // and the service will never be ready. We can be smarter and check directly that the ports are free - // but by now we Skip the test if the service is not ready and we are using endpoints with host network - if config.EndpointsHostNetwork && err != nil { - e2eskipper.Skipf("Service not ready. Pods are using hostNetwork: true, please check there is no other process on the host using the same ports: %v", err) - } framework.ExpectNoError(err, fmt.Sprintf("error while waiting for service:%s err: %v", serviceSpec.Name, err)) createdService, err := config.getServiceClient().Get(context.TODO(), serviceSpec.Name, metav1.GetOptions{})